Skip to content

fix: app icon dom nesting #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benlife5 merged 1 commit into from
Oct 5, 2026
Merged

fix: app icon dom nesting #1350

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions packages/visual-editor/src/components/assets/presetImages/AppGalleryButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
import type { AnchorHTMLAttributes } from "react";
import type { HTMLAttributes } from "react";
import { cn } from "../../../utils/cn.ts";
import { useTranslation } from "react-i18next";

export const AppGalleryButton = ({
size = "md",
...props
}: AnchorHTMLAttributes<HTMLAnchorElement> & { size?: "md" | "lg" }) => {
}: HTMLAttributes<HTMLSpanElement> & { size?: "md" | "lg" }) => {
const { t } = useTranslation();
return (
<a
<span
role="img"
aria-label={t("ariaLabelAppGallery", "Explore it on {{serviceName}}", {
serviceName: "AppGallery",
})}
{...props}
className={cn(
"rounded-[7px] bg-black ring-1 ring-app-store-badge-border outline-focus-ring ring-inset focus-visible:outline-2 focus-visible:outline-offset-2",
"rounded-[7px] bg-black ring-1 ring-app-store-badge-border ring-inset",
props.className
)}
>
Expand Down Expand Up @@ -123,6 +124,6 @@ export const AppGalleryButton = ({
fill="white"
/>
</svg>
</a>
</span>
);
};
11 changes: 6 additions & 5 deletions packages/visual-editor/src/components/assets/presetImages/AppStoreButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
import type { AnchorHTMLAttributes } from "react";
import type { HTMLAttributes } from "react";
import { cn } from "../../../utils/cn.ts";
import { useTranslation } from "react-i18next";

export const AppStoreButton = ({
size = "md",
...props
}: AnchorHTMLAttributes<HTMLAnchorElement> & { size?: "md" | "lg" }) => {
}: HTMLAttributes<HTMLSpanElement> & { size?: "md" | "lg" }) => {
const { t } = useTranslation();
return (
<a
<span
role="img"
aria-label={t("ariaLabelAppStore", "Download on the {{serviceName}}", {
serviceName: "App Store",
})}
{...props}
className={cn(
"rounded-[7px] bg-black ring-1 ring-app-store-badge-border outline-focus-ring ring-inset focus-visible:outline-2 focus-visible:outline-offset-2",
"rounded-[7px] bg-black ring-1 ring-app-store-badge-border ring-inset",
props.className
)}
>
Expand Down Expand Up @@ -114,6 +115,6 @@ export const AppStoreButton = ({
fill="white"
/>
</svg>
</a>
</span>
);
};
11 changes: 6 additions & 5 deletions packages/visual-editor/src/components/assets/presetImages/GalaxyStoreButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
import type { AnchorHTMLAttributes } from "react";
import type { HTMLAttributes } from "react";
import { cn } from "../../../utils/cn.ts";
import { useTranslation } from "react-i18next";

export const GalaxyStoreButton = ({
size = "md",
...props
}: AnchorHTMLAttributes<HTMLAnchorElement> & { size?: "md" | "lg" }) => {
}: HTMLAttributes<HTMLSpanElement> & { size?: "md" | "lg" }) => {
const { t } = useTranslation();
return (
<a
<span
role="img"
aria-label={t("ariaLabelGalaxyStore", "Available on {{serviceName}}", {
serviceName: "Galaxy Store",
})}
{...props}
className={cn(
"rounded-[7px] bg-black ring-1 ring-app-store-badge-border outline-focus-ring ring-inset focus-visible:outline-2 focus-visible:outline-offset-2",
"rounded-[7px] bg-black ring-1 ring-app-store-badge-border ring-inset",
props.className
)}
>
Expand Down Expand Up @@ -149,6 +150,6 @@ export const GalaxyStoreButton = ({
</radialGradient>
</defs>
</svg>
</a>
</span>
);
};
11 changes: 6 additions & 5 deletions packages/visual-editor/src/components/assets/presetImages/GooglePlayButton.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,20 +1,21 @@
import type { AnchorHTMLAttributes } from "react";
import type { HTMLAttributes } from "react";
import { cn } from "../../../utils/cn.ts";
import { useTranslation } from "react-i18next";

export const GooglePlayButton = ({
size = "md",
...props
}: AnchorHTMLAttributes<HTMLAnchorElement> & { size?: "md" | "lg" }) => {
}: HTMLAttributes<HTMLSpanElement> & { size?: "md" | "lg" }) => {
const { t } = useTranslation();
return (
<a
<span
role="img"
aria-label={t("ariaLabelGooglePlay", "Get it on {{serviceName}}", {
serviceName: "Google Play",
})}
{...props}
className={cn(
"rounded-[7px] bg-black ring-1 ring-app-store-badge-border outline-focus-ring ring-inset focus-visible:outline-2 focus-visible:outline-offset-2",
"rounded-[7px] bg-black ring-1 ring-app-store-badge-border ring-inset",
props.className
)}
>
Expand Down Expand Up @@ -256,6 +257,6 @@ export const GooglePlayButton = ({
</linearGradient>
</defs>
</svg>
</a>
</span>
);
};
Loading