Repository navigation
Conversation
Builds the sdist (isolated build), installs it and runs the tests outside the checkout: Linux for Python 3.9 to 3.14 and numpy<2, macOS and Windows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XUT7Yj2eYmEyHV5fiicMsP
The parser stopped a line at '\n' only, so the '\r' of a CRLF line was read as an index: 'invalid index'. save_svmfile wrote in text mode, hence CRLF on Windows, and could not read back its own files there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XUT7Yj2eYmEyHV5fiicMsP
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XUT7Yj2eYmEyHV5fiicMsP
yoch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
.github/workflows/tests.yml: builds the sdist in an isolated build, installs it, and runstests/outside the checkout so the compiled module is imported. Matrix: Linux with Python 3.9 to 3.14, Linux with Python 3.12 andnumpy<2, macOS and Windows with Python 3.13. Runs on pushes tomaster, pull requests and manual dispatch.The first Windows run found a bug, also reproducible on Linux: a file with CRLF line endings failed to load with
invalid index, because the parser ended a line at\nonly.save_svmfilewrote in text mode, hence CRLF on Windows, so it could not read back its own files there. Lines now also end at\r, andsave_svmfilewrites\non every platform. Two new tests cover this.Version bumped to 0.5.2.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XUT7Yj2eYmEyHV5fiicMsP