Repository navigation
Show the model formula in interactive fit dialogs - #10
Merged
Merged
Conversation
guifit() accepts a ormula argument displayed as a selectable rich-text label below the fit parameters. Every dialog passes the formula of its Sigima fit computer, and parameter labels show the formula symbols, so that the parameters stored in the fitted signal metadata can be related to the model (polynomial coefficients are labelled a, b, c... as in the metadata). The Planckian dialog uses Sigima's initial guess and bounds (its initial curve now matches the data peak) and labels sigma as a temperature factor. The exponential dialog evaluates Sigima's model and its rate slider covers short time constants whatever the X unit. Assisted-by: Claude Opus 5.5
Assisted-by: Claude Opus 5.5
This was referenced Oct 19, 2026
Merged
PierreRaybaut
marked this pull request as ready for review
October 20, 2026 03:46
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9
Interactive fit dialogs now show which model is fitted. They also use Sigima's model and starting values for the Planckian and exponential fits.
Changes
guifit(..., formula=...)shows the model formula as a selectable rich-text label below the fit parameters (create_formula_label).a,b,c... as in the formula and in the storedfit_params, instead ofc2,c1,c0.σis now labelled "Temperature factor", becauseσ / x₀is proportional to the temperature.ExponentialFitComputer.evaluateinstead of a localmodelfunc, and its rate slider uses Sigima's bounds, so short time constants are reachable whatever the X unit.These changes go in the direction of #3 (computation in Sigima, per-type UI presentation) without conflicting with it.
Companion PRs (merge order: Sigima → SigimaX → DataLab)
FitComputer.FORMULA, fixed Planckian/exponential computers)Validation
guifitdisplays the formula label;b = -1000, and its stored parameters reproduce the curve;