Repository navigation
Action: fork PRs get the diff in the run summary; only update our own comment - #110
Merged
Merged
Conversation
…comment. Fork PRs get a read-only token, so posting the comment failed the job; the diff now goes to the run summary. The lookup matched a marker comment by anyone, and --jq ran per page, so two matches broke the PATCH URL.
gh prints the error body on stdout, so the old fallback put it into the jq filter and the step failed on same-repo PRs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #103
Cause (
action.yml, Comment on pull request)GITHUB_TOKEN, so the POST got a 403 and failed the job.--paginate --jqruns per page, so matches on two pages gave two ids and a broken PATCH URL.Fix
$GITHUB_STEP_SUMMARY, log a notice, and skip the comment. Nopull_request_targetneeded.gh api userfor a PAT, elsegithub-actions[bot](the default token can't read/user).docs/github-action.mdnotes the fork behaviour.Verified. Ran the step's script from
action.ymlagainst a fakeghthat serves fixture comment pages:22\n33, broken PATCH URLThis PR's own
erd.ymlrun exercises the same-repo path for real. The fork path is only covered by the fake.