Repository navigation
Home page embeds: plain wheel scrolls the page, Ctrl/Cmd + wheel zooms - #112
Merged
Merged
Conversation
… pinch zooms. Both live viewers on the home page took every wheel event as zoom, so scrolling down the page shrank the diagram to a dot and the page never moved.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #98
Cause. Both live viewers on the home page (the AdventureWorks DW tour and the dbt yml demo) are the real viewer in a same-origin iframe, so the canvas took every wheel event as zoom.
Fix.
home.jswheelScrolls(ifr, stage), called byhome-tour.jsandhome-embed.jsonce the iframe loads:#canvasscrolls the home page instead.The standalone viewer is unchanged: wheel zoom stays there.
Not changed
Verified. Playwright, system Chrome, 1126x800, local
mkdocs build+ gallery: