Repository navigation
Regenerate the diff screenshot without a local path - #114
Merged
Merged
Conversation
…ve path. The old diff.png came from a scratch repo, so the details panel showed a local /private/tmp/... agent scratchpad path and placeholder columns. It now comes from the gallery's diff demo (gen_thumbnails.py diff-shot), whose change is the one the home page's sample PR comment describes.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #96
Cause.
docs/assets/img/diff.pngwas taken from a scratch repo, so the details panel showed/private/tmp/claude-501/-Users-…/scratchpad/drepo/erd/sales.txt:4. It also showed 201 tables withField0Customer-style placeholder columns.Fix
scripts/gen_thumbnails.py diff-shotnow takes the shot from the gallery'sdiffdemo (examples/quickdbd-sample.txtagainstgallery/diff/before.txt) withCustomeropen, at 1440x860 likehero.png. The panel showsexamples/quickdbd-sample.txt:4.-LegacyRef, Order+StatusandTotalmoney -> decimal(10,2), Product+Sku, 2 new tables), so "The same change, highlighted in the diagram" is now true.Checked the other screenshots.
details.pngandpath.pngshowexamples/synthetic/....hero.pnganddbt-docs.pngshowgallery/....Verified
- LegacyRef, pathexamples/quickdbd-sample.txt:4.ruff check scriptsandruff format --check scriptspass.