Repository navigation
D-121: draw the Vendor mine as a ring - #167
scrimshawlife-ctrl wants to merge 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
7e8f99b to
eb481b2
Compare
e66da87 to
bdbac16
Compare
scrimshawlife-ctrl
left a comment
There was a problem hiding this comment.
Review against accepted D-121 on specs main. This does not approve the pull request.
The renderer matches the accepted tell. The fill is clear. The stroke is white 0.92 at alpha 0.95. The width is 2 while arming and 4 while armed, in the same coordinate space as the telegraph outline. The path stays the mine radius. Arm, life, radius, damage, and the cap of two are untouched.
The pin moves together. SPEC_PIN.txt, SPEC_BASELINE.md, ContractVersions.specificationCommit, both CI greps, and the catalog specificationCommit all name b1ed874. The catalog entries are unchanged. Ruleset, content, arena, and replay identity stay.
T1060 asks for a renderer test that shows the clear fill, the stroke, the two widths, and the radius. This commit does not add that test.
The base is feat/d120-shell-copy. That branch is 54 commits behind runtime main. #166 is already on main. Merging here does not land the ring on main.
The renderer test draws an arming mine and an armed mine. The fill is clear, the stroke is white 0.92 at alpha 0.95, the widths are 2 and 4, and the path is the authored radius.
Summary
T1060. The Victorian Vendor mine is drawn as a clear-filled ring. One light neutral stroke, white 0.92 at alpha 0.95, weight 2 while arming and 4 once armed. The path stays the authoritative radius. Arm 30, life 240, radius 42, damage 12, and the cap of two are unchanged. No caption and no asset id.
Pins
b1ed874e1e8eb0e61b2174b9093201e9a61e1a4b(SS-specs #91). Ruleset staysss-rules-014. Catalog entries are unchanged; onlyspecificationCommitmoves.Stacked on #166. Merge this after that PR. The pin is #91, not #90.
Test plan
scripts/spec_parity.shagainstb1ed874e1e8eb0e61b2174b9093201e9a61e1a4bbefore this committestSharedProjectedPlayerReleaseAtEveryDisplayedPhase(releaseTicknever observed) andtestSharedProjectedPlayerTraversal(15 displayed frames, expected 16). That scene clearssnap.minesbefore render. The same two tests passed in D-119: lethal warning, option 2 #165 app Debug. Fullswift testwas not re-run on this commit.