Skip to content

D-121: draw the Vendor mine as a ring - #167

Open
scrimshawlife-ctrl wants to merge 2 commits into
feat/d120-shell-copyfrom
feat/d121-mine-tell
Open

scrimshawlife-ctrl wants to merge 2 commits into
feat/d120-shell-copyfrom
feat/d121-mine-tell

Conversation

@scrimshawlife-ctrl

Copy link
Copy Markdown
Collaborator

Summary

T1060. The Victorian Vendor mine is drawn as a clear-filled ring. One light neutral stroke, white 0.92 at alpha 0.95, weight 2 while arming and 4 once armed. The path stays the authoritative radius. Arm 30, life 240, radius 42, damage 12, and the cap of two are unchanged. No caption and no asset id.

Pins b1ed874e1e8eb0e61b2174b9093201e9a61e1a4b (SS-specs #91). Ruleset stays ss-rules-014. Catalog entries are unchanged; only specificationCommit moves.

Stacked on #166. Merge this after that PR. The pin is #91, not #90.

Test plan

  • scripts/spec_parity.sh against b1ed874e1e8eb0e61b2174b9093201e9a61e1a4b before this commit
  • CI: swift, spec-parity, app Debug, app Release
  • Local Debug app scheme is not claimed green. 112 Swift tests in 20 suites passed. Two XCTest cases failed under skipped SpriteKit frames: testSharedProjectedPlayerReleaseAtEveryDisplayedPhase (releaseTick never observed) and testSharedProjectedPlayerTraversal (15 displayed frames, expected 16). That scene clears snap.mines before render. The same two tests passed in D-119: lethal warning, option 2 #165 app Debug. Full swift test was not re-run on this commit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-02T06:12:58.896095Z e66da87 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@scrimshawlife-ctrl scrimshawlife-ctrl left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review against accepted D-121 on specs main. This does not approve the pull request.

The renderer matches the accepted tell. The fill is clear. The stroke is white 0.92 at alpha 0.95. The width is 2 while arming and 4 while armed, in the same coordinate space as the telegraph outline. The path stays the mine radius. Arm, life, radius, damage, and the cap of two are untouched.

The pin moves together. SPEC_PIN.txt, SPEC_BASELINE.md, ContractVersions.specificationCommit, both CI greps, and the catalog specificationCommit all name b1ed874. The catalog entries are unchanged. Ruleset, content, arena, and replay identity stay.

T1060 asks for a renderer test that shows the clear fill, the stroke, the two widths, and the radius. This commit does not add that test.

The base is feat/d120-shell-copy. That branch is 54 commits behind runtime main. #166 is already on main. Merging here does not land the ring on main.

The renderer test draws an arming mine and an armed mine. The fill is clear, the stroke is white 0.92 at alpha 0.95, the widths are 2 and 4, and the path is the authored radius.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant