Repository navigation
soc: apple: mailbox: Add the physical T6050 GPU windows - #1275
Conversation
Describe the ASCWrap v6 compatible for the physical GPU aperture shared by J775D and J716c, distinct from the existing T6050 alias profiles. Signed-off-by: Jeff Queisser <funkzy@users.noreply.github.com> Developed with Claude Code. Signed-off-by: Erik Bourget <erik@ebourget.net>
The existing T6050 profiles validate alias addresses and reject the physical GFX/GFX1 resources used on J716c. Add the shared J775D/J716c profile for 0x2302600000 and 0x2302e00000, including their vector-base registers. Reuse the ASCWrap v6 transport and retain all existing address profiles. Signed-off-by: Jeff Queisser <funkzy@users.noreply.github.com> Developed with Claude Code. Signed-off-by: Erik Bourget <erik@ebourget.net>
DjDeveloperr
left a comment
DjDeveloperr
left a comment
There was a problem hiding this comment.
Tested on the 14-inch M5 Pro (J714sAP, T6050, macOS 27.0 firmware). It works.
Setup: RAM boot through aura (Stage 2 431f60d1-based) of the PR1012 +platform kernel. Our local bare-metal mailbox commit was replaced by this PR's two commits (cherry-picked unchanged), and the kit's GPU DT selects apple,t6050-j775d-ascwrap-v6 for GFX and GFX1. 18 CPUs, modules nvme, display, smc, input, gpu.
Evidence (console):
2302600000.mailbox -> apple-mailbox,2302e00000.mailbox -> apple-mailbox. No "ASCWrap v6 resources do not match the SoC", and the only deferred device is the unrelated keyboard-backlight PWM.aurora 2300000000.gpu: GPU firmware build: 26A428 for T6050 G17S, primary then secondary, MMU initialized, RTKit up on both roles,M5 firmware graph ready,[drm] Initialized aurora 1.0.0 for 2300000000.gpu on minor 0.
The J714sAP ADT has the same physical windows as this profile (gfx-asc 0x2302600000 / iop-vbar 0x2302050000, gfx1-asc 0x2302e00000 / 0x2302850000), so the M5 Pro can use it as is. Our equivalent local patch can be dropped in favour of this one.
Non-blocking: the profile now serves J775D, J716c and J714s. A SoC-level name (for example apple,t6050-phys-ascwrap-v6) would read better than j775d, but that's cosmetic.
|
Retested before merging on the M5 Pro (J714sAP, bare metal, SSD boot), kernel 7.3.0-m5-merge: the M5's integration kernel with this round's rebased heads in place of the old ones (every PR's own patch identical to what is merged; logs in work/m5-pr-merge-20261109). CI green. Before merging, this round (these 14 PRs, #1323 and the rebased #1254/#1306/#938/#1316/#1199) was test-merged in order onto integration/aurora f9cf6f9 with no conflicts:
🤖 Generated with Claude Code |
The existing T6050 mailbox profiles accept alias addresses and reject the physical GFX/GFX1 windows on J716c, leaving the GPU waiting for its mailbox suppliers. Add the physical GPU profile shared by J775D and J716c, with its two wrapper and vector-base resources, and reuse the existing ASCWrap v6 transport. Existing profiles retain their mappings.
Based directly on
integration/aurora; no open PR dependency. The J716c GPU/panel device-tree PR selects this profile.Validation: binding document and focused compiled-DT checks pass; both commits pass checkpatch. The complete public J716c stack builds Image.gz, modules and DTB. Its driver role table was compiled in a host-side resource check and matches the translated device-tree addresses and sizes. The prior alias profile is rejected by the same check. The complete public stack booted on J716c with this exact mailbox change: both GPU mailboxes probed, the G17C driver initialized, and matching public Mesa enumerated the Apple M5 Max Vulkan device. The desktop rendered on the internal display. The later complete public stack also passed a user-confirmed rear-left-attached TS5 reboot with internal and external displays, dock input and Ethernet.
Created with GPT-6 Astra in Codex.