Repository navigation
Replace legacy bulk uploads with eager ingestion completions - #155
Open
Stephen Belanger (Qard) wants to merge 1 commit into
Open
Stephen Belanger (Qard) wants to merge 1 commit into
Stephen Belanger (Qard) wants to merge 1 commit into
Conversation
Stephen Belanger (Qard)
force-pushed
the
refactor/ingestion-batch-api
branch
from
October 23, 2026 15:26
9421a70 to
76fe249
Compare
This was referenced Oct 23, 2026
Stephen Belanger (Qard)
force-pushed
the
refactor/stream-components
branch
from
October 28, 2026 12:05
b183ffb to
d5094cf
Compare
Stephen Belanger (Qard)
force-pushed
the
refactor/ingestion-batch-api
branch
from
October 28, 2026 12:05
76fe249 to
75969cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the root-level
Logs3BatchUploadercompatibility adapter withingest::BatchUploader, a concrete bulk-ingestion client using explicitapi::Config.upload_rowstakes an owned batch and returns an eager completion, with shared bounded admission, fixed runtime ownership and shutdown. Clones share capability discovery and lifecycle.Preserve the existing bulk-import batching, splitting, retries, overflow protocol and accounting through the same private upload coordinator. The direct
api::Clientremains one-attempt. No manual-delivery mode is added to resource logging. Reuse the direct client's execution lifecycle instead of creating a second task registry or uploader runtime policy.Validation: 447 unit/integration tests passed; 20 doctests passed (four existing ignored). Strict Clippy, rustdoc, formatting and diff checks passed. Rust 1.86 passed bulk-upload tests and package verification with a fresh offline graph. Coverage verifies 413 splitting, overflow, CA validation, unpolled progress, dropped observers, shared shutdown and fresh batches after terminal failure. Both downstream consumers compile against the replacement; their migration PRs coordinate exact pins and lockfiles.
Stacked on #154. This completes the SDK-side legacy bulk-uploader migration from release-preparation stage 9. Do not land before the coordinated consumer PRs are ready.
Coordinated consumer PRs: daemon #217 and bt #441.