Repository navigation
MODEUS-243: Remove aggregator settings and fields - #239
Merged
elsenhans merged 9 commits intoOct 12, 2026
Merged
Conversation
…dd mirgation skript
…pt mirgation order
alb3rtino
marked this pull request as draft
October 7, 2026 17:53
Contributor
|
Looking good so far. Moving it to draft so it doesn't get merged accidentally, as this work is waiting to be merged together with MODEUSHARV-186 and UIEUS-564. ☝️ |
alb3rtino
reviewed
Oct 7, 2026
alb3rtino
left a comment
alb3rtino
left a comment
Contributor
There was a problem hiding this comment.
We need to discuss how to handle the migration. Two things:
- Deactivated aggregator providers lose their
vendorCode. - Deactivated aggregator providers can't be distinguished from providers that had been inactive before the migration.
…vendorCode info in description
alb3rtino
marked this pull request as ready for review
October 9, 2026 16:17
alb3rtino
approved these changes
Oct 9, 2026
elsenhans
added a commit
to folio-org/ui-erm-usage
that referenced
this pull request
Oct 12, 2026
…and erm-usage-harvester 3.0 (#655) ## Description [UIEUS-564](https://folio-org.atlassian.net/browse/UIEUS-564) Follow-up to https://folio-org.atlassian.net/browse/UIEUS-562 once `mod-erm-usage` and `mod-erm-usage-harvester` are released without the aggregator fields: `ui-erm-usage` stops writing `harvestingConfig.harvestVia` and requires the new interface versions. Blocked until both backend releases exist. ## Approach - Remove `withHarvestVia` (util, test, calls in `UDPCreateRoute` and `UDPEditRoute`) and the constant `HARVEST_VIA_SUSHI` - The UI no longer writes `harvestingConfig.harvestVia` - Remove `?aggregator=false` from all `erm-usage-harvester/impl` requests - Require `usage-data-providers 4.0` and `erm-usage-harvester 3.0` - Remove `harvestVia` from the test fixtures - `UDPEditRoute` save test (no longer expects `harvestVia`) ## Dependencies - need to be merged together with: folio-org/mod-erm-usage#239 and folio-org/mod-erm-usage-harvester#232 [UIEUS-564]: https://folio-org.atlassian.net/browse/UIEUS-564?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: elsenhans <elsenhans@users.noreply.github.com>
|
elsenhans
deleted the
MODEUS-243-remove-aggregator-settings-and-fields
branch
October 12, 2026 07:38
elsenhans
added a commit
to folio-org/mod-erm-usage-harvester
that referenced
this pull request
Oct 12, 2026
…r 3.0), require usage-data-providers 4.0 (#232) ## Description Drop `isAggregator` and `?aggregator` (erm-usage-harvester 3.0), require usage-data-providers 4.0 [MODEUSHARV-186](https://folio-org.atlassian.net/browse/MODEUSHARV-186) ## Approach - Bump `mod-erm-usage-client` to `6.0.0`, the `mod-erm-usage` release without `harvestVia`, `aggregator` and `AggregatorSettingsClient`. - Module descriptor: - require `usage-data-providers` 4.0 - provide `erm-usage-harvester` 3.0 (major bump because fields and a query parameter are removed) - `GET /erm-usage-harvester/impl`: - remove the `aggregator` query parameter - `ErmUsageHarvesterAPI` always returns all available implementations (no aggregator parameter anymore) - `serviceImplementation.json`: remove `isAggregator` and `configurationParameters` - Tests: - remove the `?aggregator=true/false` cases from `ErmUsageHarvesterAPITest` - remove the `harvestVia` and aggregator tests from `ServiceEndpointFactoryTest` - remove `harvestVia` from `TestUtil` and `HarvestingIT` - Test fixtures: - remove `harvestVia` from `usage-data-provider.json` and `usage-data-providers.json` - drop the "without harvestVia" provider, instead of 3 `totalRecords` they are just 2 now. - Docs: - remove `isAggregator` and `configurationParameters` from the README `/impl` example ## Dependencies - CI fails until `mod-erm-usage-client` 6.0.0 is published - need to be merged together with [MODEUSHARV-243](folio-org/mod-erm-usage#239) and UIEUS-564 [MODEUSHARV-186]: https://folio-org.atlassian.net/browse/MODEUSHARV-186?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ --------- Co-authored-by: elsenhans <elsenhans@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
MODEUS-243
Purpose
MODEUS-243: Remove the aggregator settings and the aggregator fields of the UDP. Migrate existing aggregator UDPs.
Approach
aggregator-settingsinterface: RAML, schemas,AggregatorSettingsAPI,ExportObjectandaggregatorsettings.*permissionsharvestViaandaggregatorfromudprovider.json, the indexes, the searchable/orderable lists and the CQL examplesusage-data-providersto4.0and the module to6.0.0(breaking changes)migration/6.0.0/migrate_remove_aggregator.sql:usage_data_providers_custom_aggregatorid_idxand theaggregator_settingstable first (allIF EXISTS, the script also runs on fresh installs)harvestingStatustoinactivefor UDPs withharvestVia = "aggregator"harvestViaandaggregatorfrom all UDPsUpgrade notes
/aggregator-settingsand/aggregator-settings/{id}/exportcredentialsbefore upgrading; the data is droppedharvestVia. Must be deployed before or together with this module, since the current harvester fails on every UDP withoutharvestViausage-data-providers 4.0. Release as one set with this PR, since the module dependency check accepts 4.0 only when every consumer requires itTests
UsageDataProvidersIT,SQLTriggersIT,CustomIndexesITand the samplesMigrateRemoveAggregatorIT: Recreates the aggregator objects and UDPs of 5.2.0, runs the tenant upgrade to 6.0.0 and checks that aggregator UDPs are deactivated, SUSHI UDPs stay active and all aggregator objects are gone