Repository navigation
Conversation
This was referenced Oct 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Complete the API-reference correction for existing property contracts: six ExcelFormat getters/setters accept null to read without changing the value, while false remains a setter value. Correct two ExcelSheet parameter annotations and document getIndexRange() warning-plus-false behavior for negative indexes and, on 64-bit PHP, indexes above INT_MAX.
Only nine docblocks and the Unreleased documentation note change. Runtime, signatures and tests are unchanged.
Validation
Limitations
Local build used retained official headers/library and direct compiler invocation, not a fresh phpize/configure install. Seven license/platform skips are not passes; no local Windows, ZTS, sanitizer or performance claim. Exact-head CI completed successfully: Tests run 40156107945 and Windows Build run 40156107911, all 36 executed jobs passed. One release-upload job was intentionally skipped, not passed. The workflow-security scan is path-filtered out for this docs-only change.
Audited CI logs: PHP 8.4 Linux 252 passed / 9 skipped; PHP 8.4 ZTS 253 / 8; Windows PHP 8.4 x64 NTS 247 / 14; both ASAN lanes 250 / 9 plus two isolated tests passed. All inspected summaries have zero failures or warnings.