Repository navigation
[CI] Run ARM CI through the x86 test action and re-enable ARM tests - #8233
Conversation
|
run-ci |
|
run-ci |
|
run-ci |
|
run-ci |
|
run-ci |
|
run-ci |
ARM CI called run-tests directly in two containers split by OVPhysX, without the Warp and OVRTX shader caches x86 restores. Let run-package-tests use an image already built on the runner and pass a pytest marker through, then run the arm_ci tests in one step with the x86 kit-less settings: OVPhysX and OVRTX cases together, ovstage deselected, caches restored on pull requests and published on pushes.
Installation Tests (ARM) already runs the same three Cartpole probes on the Spark pool, and x86's Docker CI has no such step, so ARM CI's separate smoke step only repeated them.
…s on ARM Both were disabled on ARM for real failures: the shadow-hand kit-less rendering file stalled mid-run on arm64 (isaac-sim#6581), and Isaac Sim PhysX training failed at environment creation on aarch64 with an invalidated simulation view. Restore the arm_ci marker and drop the aarch64 skip so DGX Spark runs both again.
test_operational_space.py set pytestmark to arm_ci and then reassigned it to integration, so ARM CI's -m arm_ci deselected all of its tests. Declare both markers in one list at the top of the file.
No x86 job selects this file: the task package jobs exclude rendering tests and the kit-less rendering job lists its files explicitly without it. Drop its arm_ci marker so ARM CI runs the same rendering files as x86.
657a8c5 to
8938bf9
Compare
|
run-ci |
This reverts commit 3db7d91.
|
run-ci |
|
| - name: Run Cartpole smoke tests | ||
| uses: ./.github/actions/run-tests |
There was a problem hiding this comment.
On protected-branch pushes, run-package-tests saves both caches before this Cartpole step runs. Any cache files added by the state or camera probes miss the published snapshot, so later PRs may compile them again. Run these probes before the action saves the caches, as the PR description intends.
| return ( | ||
| "enable_cameras=True" in test_content | ||
| or "ovrtx" in test_content.lower() | ||
| or "rendering_test_utils" in test_content |
There was a problem hiding this comment.
Helper tests occupy rendering lane
Importing rendering_test_utils does not mean a test starts a renderer. This now marks test_maybe_save_stage_golden.py as a rendering file, although it writes USD files and mocks isaaclab.sim.save_stage. The scheduler unnecessarily blocks it from running beside real rendering files and gives it the cold-shader timeout allowance. Use a narrower check and cover this helper-only test in the classifier tests.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
There was a problem hiding this comment.
Isaac Lab Review Bot
Needs attention: Design and architecture (1). Other reviewed categories look good.
- PR description: Performance evidence supplies revisions, workloads, hardware, driver, and timings, but item 2 misstates cache ordering; smoke probes run after
run-package-tests, so correct the claim or move them before cache saving. - Design and architecture: Inferring daemon export from empty cache inputs breaks documented no-ECR fallbacks on runners without containerd image storage; add an explicit builder or export-mode input.
- Scope and over-engineering: No over-engineering issues.
- API: API changes look good.
- Compatibility and deprecation: No breaking changes identified.
- Implementation: Implementation looks good.
- Style consistency: Style consistency looks good.
- Test quality: Test quality looks good.
Minor fixes needed. Posted 1 inline finding.
Automated review; human maintainers own approval decisions.
| # image, layer cache and uv cache mount stay on the runner. A containerd | ||
| # image store still compresses new layers; zstd level 1 is several times | ||
| # faster than the default gzip for the multi-GB venv layer. | ||
| if [ -n "${{ inputs.cache-from }}${{ inputs.cache-to }}" ]; then |
There was a problem hiding this comment.
🟡 Warning · Design Architecture — Builder choice inferred from cache inputs
Empty cache inputs also occur on ecr-build-push-pull's documented no-ECR fallback, so those builds now export via --output type=image on the default builder, which fails without a containerd image store. Gate on an explicit input.
release/3.0.0 still has the cli/, uv_pip/ and uv_run/ install_ci layout, so the conflicting #8233 hunks have no direct target. The proposed resolution instead ported develop's workspace fixtures, test_workspace.py and a --run-gpu gate that nothing on this branch passes. Its module-level tomllib import broke x86 test collection on Python 3.10, and the gate skipped existing ARM training tests. Restore conftest.py, drop test_workspace.py, and carry the actual change: re-enable Isaac Sim PhysX training on aarch64 in the uv_run test that test_workspace.py replaced on develop. That test already preserves the ARM OpenMP preload when it adds the Carbonite shim.
#8233 dropped installation CI from the probe's caller list because develop's install suite no longer runs it. On release/3.0.0 the uv pip wheel install test still executes this file through the cartpole_smoke_script fixture, so name all three callers.
Backports #8233 to `release/3.0.0`. The original cherry-pick conflicted. An NVIDIA inference model proposed this resolution, and deterministic validation confirmed that it changes no paths outside the original PR. Because conflict resolution cannot be certified as an exact patch replay, this PR is intentionally a draft and requires release-maintainer review. | Field | Commit | |---|---| | Original merged change | `8519738d0c984a2a5bfddc161f60f59606c3b394` | | Release base used | `8ce1df03bf5256f0d8fc2e76d021c2d186e36a02` | | Proposed backport | `6fc6b0968833ca1dd1fe5e37c98ba2c5701a99b1` | --------- Co-authored-by: hujc <jichuanh@nvidia.com> Co-authored-by: Antoine RICHARD <antoiner@nvidia.com>
Summary
ARM CI restores compatible Warp and OVRTX caches and runs Newton/OVPhysX marker coverage through the shared x86 test action. Camera smoke coverage stays enabled, and previously skipped ARM checks are restored.
Description
run-package-tests, with explicitlinux/arm64passed through image lookup, dependency hashing and fallback builds. PRs restore ARM caches; protected-branch pushes publish them. Test files run in four slots like the x86 test jobs; rendering files still run one at a time.run-package-testsnow exposes as outputs. Installation CI now covers state training separately, so the camera probes remain necessary. The step checks the probe report explicitly, sincerun-testsrecords failures in the report rather than its exit code.docker-containerbuilder exported and reloaded the ~29 GB image every build and discarded its layer cache. Only ARM takes this path today: x86 callers resolve ECR and keep thedocker-containerbuilder. The action is part of the dependency-cache hash, so the first build after merge misses that cache once.rendering_test_utilsas renderers, so their cold shader compiles no longer run concurrently.Validation
uv run --frozen --extra test isaaclab -f: all checks passed.Docker-storage and file-scheduler coverage: 19 tests passed. Actionlint passed for ARM and x86 workflows; 50 local action calls validated against their declared inputs.
A real subprocess regression check failed before the preload fix and passes afterward for ARM with/without the shim and x86 with the shim.
On
7b73dafe1fe, ARM CI passed 71 marker cases (3 expected skips) and all 3 state/camera smoke probes. ARM installation passed 3/3 attempts on three NVIDIA GB10 runners, with all 8 contracts including PhysX executed each time; x86 installation also passed all 8 contracts.On the final head
01a3ff4737d, the x86 Docker suite passed: 30 jobs succeeded and 3 post-merge-only jobs were skipped as expected. Hosted pre-commit, Tools Tests, Docs, kitless image validation, installation and multi-GPU CI also passed.ARM job time, all on NVIDIA GB10 with driver 580.159.03. A temporary commit (since reverted) let PR runs save caches for this measurement:
The first four rows also included the Newton RTX shader-cache fix, now split into Redirect the Newton RTX visualizer shader cache #8504; the final head does not. Warm per-file times: Cartpole 54 s (was 297 s), Kuka 51 s, Shadow Hand 41 s, operational space 118 s alongside them. Newton RTX takes 254 s without Redirect the Newton RTX visualizer shader cache #8504 and 27 s with it. Every run passed 71 marker cases (3 expected skips) and 3 smoke probes. Image export on the runners' containerd store fell from 243 s with gzip to 44–46 s with zstd. Protected-branch publication remains unmeasured before merge.
Type of change
Release backport
developChecklist
pre-commitchecks withuv run isaaclab --formatCONTRIBUTORS.md