Repository navigation
[CI] Run ARM CI through the x86 test action and re-enable ARM tests #8233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
6456905
a018260
4489717
adccfae
8938bf9
3c22994
7850851
a7e156c
bd5f11f
de9960c
097d6b0
f6b0e2d
8fa6f50
735bef8
7b73daf
1bfed29
211ff55
a29615a
3392b80
3db7d91
dd17bc1
998d850
2954457
62226c7
5a940d4
d02aedd
01a3ff4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -174,40 +174,53 @@ jobs: | |
| uses: ./.github/actions/resolve-ov-pins | ||
| id: ov_pins | ||
|
|
||
| # Same action as the x86 test jobs, with four file slots; rendering files still | ||
| # run one at a time. With no ECR on the Spark, it picks up the image built above from the local | ||
| # store. Pushes to protected branches publish the arm64 Warp and OVRTX caches | ||
| # that pull requests restore, the role x86's cache-warm jobs play. | ||
| - name: Run arm_ci marker tests | ||
| uses: ./.github/actions/run-tests | ||
| id: tests | ||
| uses: ./.github/actions/run-package-tests | ||
| with: | ||
| test-path: tools | ||
| result-file: arm-ci-report.xml | ||
| container-name: isaac-lab-arm-ci-${{ github.run_id }}-${{ github.run_attempt }} | ||
| image-tag: ${{ needs.config.outputs.ci_image_tag }}-arm64 | ||
| extra-pip-packages: "${{ steps.ov_pins.outputs.ovrtx }} ${{ steps.ov_pins.outputs.ovphysx }}" | ||
| # ovstage rendering cases are post-merge only on x86 as well. | ||
| test-k-expr: not ovphysx and not ovstage | ||
| platform: linux/arm64 | ||
| isaacsim-base-image: ${{ needs.config.outputs.isaacsim_image_name }} | ||
| isaacsim-version: ${{ needs.config.outputs.isaacsim_image_tag }} | ||
| ci-marker: arm_ci | ||
| volume-mount-source: ${{ github.workspace }} | ||
|
|
||
| - name: Run arm_ci OVPhysX marker tests | ||
| uses: ./.github/actions/run-tests | ||
| with: | ||
| test-path: tools | ||
| result-file: arm-ci-ovphysx-report.xml | ||
| container-name: isaac-lab-arm-ci-ovphysx-${{ github.run_id }}-${{ github.run_attempt }} | ||
| image-tag: ${{ needs.config.outputs.ci_image_tag }}-arm64 | ||
| # ovstage rendering cases are post-merge only on x86 as well. | ||
| test-k-expr: not ovstage | ||
| test-jobs: "4" | ||
| extra-pip-packages: "${{ steps.ov_pins.outputs.ovrtx }} ${{ steps.ov_pins.outputs.ovphysx }}" | ||
| test-k-expr: ovphysx and not ovstage | ||
| ci-marker: arm_ci | ||
| volume-mount-source: ${{ github.workspace }} | ||
|
|
||
| warp-cache: ${{ github.event_name == 'push' && 'save' || 'restore' }} | ||
| ovrtx-shader-cache: ${{ github.event_name == 'push' && 'save' || 'restore' }} | ||
| ovrtx-shader-cache-trees: kitless | ||
| result-file: arm-ci-report.xml | ||
| container-name: isaac-lab-arm-ci | ||
| omni-github-test-type: arm-ci | ||
|
|
||
| - name: Run shared Cartpole smoke | ||
| # The test orchestrator skips install_ci/, so the Cartpole state/camera probes | ||
| # run here in the same image, reusing the restored Warp and OVRTX caches. | ||
| - name: Run Cartpole smoke tests | ||
| uses: ./.github/actions/run-tests | ||
|
Comment on lines
+203
to
204
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. On protected-branch pushes, |
||
| with: | ||
| test-path: source/isaaclab/test/install_ci/misc/cartpole_training_smoke.py | ||
| result-file: arm-ci-cartpole-smoke-report.xml | ||
| container-name: isaac-lab-arm-ci-cartpole-${{ github.run_id }}-${{ github.run_attempt }} | ||
| result-file: arm-ci-smoke-report.xml | ||
| container-name: isaac-lab-arm-ci-smoke-${{ github.run_id }}-${{ github.run_attempt }} | ||
| image-tag: ${{ needs.config.outputs.ci_image_tag }}-arm64 | ||
| volume-mount-source: ${{ github.workspace }} | ||
| warp-cache-host-dir: ${{ steps.tests.outputs.warp-cache-host-dir }} | ||
| ovrtx-shader-cache-host-dir: ${{ steps.tests.outputs.ovrtx-shader-cache-host-dir }} | ||
| omni-github-test-type: arm-ci | ||
|
|
||
| # run-tests records failures in the report rather than its exit code. | ||
| - name: Check Cartpole smoke results | ||
| shell: bash | ||
| run: | | ||
| report=reports/arm-ci-smoke-report.xml | ||
| if [ ! -f "$report" ] || grep -qE '(failures|errors)="[1-9][0-9]*"' "$report"; then | ||
| echo "::error::Cartpole smoke tests failed or produced no report: $report" | ||
| exit 1 | ||
| fi | ||
| - name: Upload test reports | ||
| if: always() | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1402,8 +1402,15 @@ def _run_one_pass( | |
|
|
||
|
|
||
| def _starts_renderer(test_content: str) -> bool: | ||
| """Return whether a test file's source starts an RTX renderer: Kit's, by enabling cameras, or OVRTX.""" | ||
| return "enable_cameras=True" in test_content or "ovrtx" in test_content.lower() | ||
| """Return whether a test file's source starts an RTX renderer: Kit's, by enabling cameras, or OVRTX. | ||
|
|
||
| Files built on ``rendering_test_utils`` pick their renderer through its helpers, so they name neither. | ||
| """ | ||
| return ( | ||
| "enable_cameras=True" in test_content | ||
| or "ovrtx" in test_content.lower() | ||
| or "rendering_test_utils" in test_content | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Importing Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||
| ) | ||
|
|
||
|
|
||
| def _test_file_job(test_file: str, max_slots: int) -> TestFileJob: | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Warning · Design Architecture — Builder choice inferred from cache inputs
Empty cache inputs also occur on ecr-build-push-pull's documented no-ECR fallback, so those builds now export via
--output type=imageon the default builder, which fails without a containerd image store. Gate on an explicit input.