Repository navigation
Skip marker jobs with no marked test file before they start - #8744
Draft
ben-johnston-nv wants to merge 9 commits into
Draft
ben-johnston-nv wants to merge 9 commits into
ben-johnston-nv wants to merge 9 commits into
Conversation
A workflow_dispatch input forwards one registered marker to every test job. A job with no marked file passes with an empty report, and an unregistered marker fails the job before selection.
Read registered markers from pytest's loaded config instead of re-parsing pyproject.toml, test the rejection and empty-selection exits through pytest_sessionstart, and match the sibling marker order in the Shadow Hand rendering test.
# Conflicts: # source/isaaclab_ov/test/test_ovrtx_compat.py # source/isaaclab_ov/test/test_ovstage_compat.py # source/isaaclab_ov/test/test_runtime_imports.py
A marker run decides in the config job which test jobs select a file carrying the marker, using the same file selection as tools/conftest.py. Jobs with nothing to run are skipped instead of waiting for a GPU runner and pulling the CI image only to pass with an empty report.
6 of 8 tasks
Contributor
Author
|
run-ci |
isaaclab-bot
Bot
added
ci:run-docker
Contributor
Author
|
Validation:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #8609, and stacked on it: this branch contains #8609 merged with current
develop, so the diff includes its commits until it merges. The change in this PR is the last commit, 365d384.#8609 leaves this as a follow-up: under a
markerrun, a job with no marked test file still waits for a GPU runner and pulls the CI image, then passes with an empty report. This PR skips those jobs before they start.tools/conftest.pyintotools/test_selection.py, which imports only the standard library andtest_settings. The orchestrator calls it unchanged.tools/ci_marker_jobs.pyreads each job'srun-package-testsinputs frombuild.yaml, applies the same selection (including the legacynot <pattern>filter, shards and node-ID subsets), and reports which jobs select a marked file. An input it cannot evaluate keeps the job running.markeris set. Every job that forwards the marker gets(!inputs.marker || fromJSON(needs.config.outputs.marker_jobs)['<job>'])in itsif:. Runs without a marker are unchanged.tools/test_ci_marker_jobs.pyfails if a job forwards the marker without the matching gate. It runs in Tools Tests, which now also triggers onbuild.yamlchanges.The empty-report path in the container stays as a backstop.
Expected effect for
kitlessThe check keeps 9 of the 26 marker jobs. Job by job, it agrees with which jobs ran tests and which passed empty in the
kitlessrun 38775752803 from #8609. File counts differ slightly becausedevelophas moved since. Runners that pull the image slowly gain the most; on ours, each skipped job saves about 10 minutes of runner wait and image pull.Type of change
Release backport
developChecklist
Docker and GPU tests run on demand. Push the commits you want tested, then
comment
run-cion the pull request.pre-commitchecks withuv run isaaclab --formatsource/<pkg>/changelog.d/for every touched package (do not editCHANGELOG.rstor bump package versions — CI handles that)CONTRIBUTORS.mdor my name already exists thereNot yet run in GitHub Actions: the Load Config sparse checkout and the new
if:expressions need amarker=kitlessdispatch to confirm.🤖 Generated with Claude Code