Repository navigation
[DO NOT MERGE] Diagnostic kitless run for #8744 - #8746
Closed
ben-johnston-nv wants to merge 10 commits into
Closed
ben-johnston-nv wants to merge 10 commits into
ben-johnston-nv wants to merge 10 commits into
Conversation
A workflow_dispatch input forwards one registered marker to every test job. A job with no marked file passes with an empty report, and an unregistered marker fails the job before selection.
Read registered markers from pytest's loaded config instead of re-parsing pyproject.toml, test the rejection and empty-selection exits through pytest_sessionstart, and match the sibling marker order in the Shadow Hand rendering test.
# Conflicts: # source/isaaclab_ov/test/test_ovrtx_compat.py # source/isaaclab_ov/test/test_ovstage_compat.py # source/isaaclab_ov/test/test_runtime_imports.py
A marker run decides in the config job which test jobs select a file carrying the marker, using the same file selection as tools/conftest.py. Jobs with nothing to run are skipped instead of waiting for a GPU runner and pulling the CI image only to pass with an empty report.
Temporary: lets a pull_request run exercise the marker job gating. Not for merge.
Contributor
Author
|
run-ci |
isaaclab-bot
Bot
added
ci:run-docker
Contributor
Author
|
Diagnostic run done (39330427436); results are on #8744. |
6 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Temporary diagnostic PR, to be closed after one CI run. Not for review or merge.
Stacks one commit on #8744 that defaults the CI marker to
kitless, so arun-cipull-request run exercises the marker job gating. Expected: of the GPU test jobs, only the 7 withkitlessfiles that already run on pull requests start (isaaclab_tasks [1/3],isaaclab (core) [1/3]and[2/3],isaaclab_visualizers,isaaclab_newton,isaaclab_ov,rendering-correctness-kitless (legacy)); the rest show as skipped.🤖 Generated with Claude Code