Repository navigation
Expose regular argument attributes in rustc_public - #163242
Merged
rust-bors[bot] merged 4 commits intoOct 10, 2026
Merged
Conversation
rustbot
added
S-waiting-on-review
Collaborator
|
Thanks for the pull request, and welcome! The Rust Project has assigned @makai410 (or someone else) to review your changes, you should hear from them (or someone else) within the next two weeks. Please see the contribution instructions and our LLM policy for more information. |
makai410
reviewed
Oct 1, 2026
makai410
reviewed
Oct 3, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
makai410
reviewed
Oct 7, 2026
This comment has been minimized.
This comment has been minimized.
nihalpasham
force-pushed
the
rustc-public-arg-attributes
branch
from
October 10, 2026 06:07
ced5097 to
8a0c5b6
Compare
Collaborator
|
This PR was rebased onto a different main commit. Here's a range-diff highlighting what actually changed. Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers. |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 10, 2026
Rollup merge of #163242 - nihalpasham:rustc-public-arg-attributes, r=makai410 Expose regular argument attributes in rustc_public Add `ArgAttributes::regular()` and `ArgAttributeFlags` so consumers can read the argument flags already computed by rustc. The conversion preserves all ten flags, including the overlapping capture flags. Clarifies what `pointee_size` guarantees at function entry and return, and how `no_free` affects rustc's emission of LLVM dereferenceability attributes. Fixes rust-lang/rustc_public#132. r? @makai410
2 tasks done
nihalpasham
added a commit
to NVIDIA/cuda-rust
that referenced
this pull request
Oct 11, 2026
Update CUDAoxide from `nightly-2026-08-28` to `nightly-2026-10-11`. This brings in rust-lang/rust#163242, needed for the separate kernel parameter-attribute work in #1483 (related to #1088 and #1098). ## Changes - Adapt to rustc API changes, generic floating-point intrinsics, and integer min/max. - Follow the new `core::intrinsics::reflection::type_id` path in the kernel-name helper. - Update toolchain/Nix pins, diagnostic snapshots, and intrinsic evidence. Intrinsic declarations are unchanged. ## Validation - CI: 55 passed, 7 expected skips; all 234 examples compile. - Compiler tests, formatting, clippy, and IR comparison pass. Targeted checks pass on both RTX 5090s with no memcheck errors. - GPU sweep: 232/233 passed. The existing FP8 example failure is addressed separately in #1487; hardware-limited cases retain compile-only coverage. The existing scaffold issue—mixing registry and Git runtime types—also remains a separate follow-up. ## Checklist - [x] All commits signed off - [x] SPDX headers on new source files, where applicable --------- Signed-off-by: nihalp <nihalp@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
ArgAttributes::regular()andArgAttributeFlagsso consumers can read the argument flags already computed by rustc. The conversion preserves all ten flags, including the overlapping capture flags.Clarifies what
pointee_sizeguarantees at function entry and return, and howno_freeaffects rustc's emission of LLVM dereferenceability attributes.Fixes rust-lang/rustc_public#132.
r? @makai410