Skip to content

Remove deprecated PercentCompleted - #1055

Merged
Enkidu93 merged 1 commit into
mainfrom
remove_percent_completed
Oct 1, 2026
Merged

Enkidu93 merged 1 commit into
mainfrom
remove_percent_completed

Conversation

@pmachapman

@pmachapman pmachapman commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes #1018


This change is Reviewable

@pmachapman
pmachapman requested a review from Enkidu93 September 30, 2026 19:58
@codecov-commenter

codecov-commenter commented Sep 30, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.82%. Comparing base (231bcba) to head (89f53cc).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
+ Coverage   72.79%   72.82%   +0.02%     
==========================================
  Files         390      391       +1     
  Lines       21715    21735      +20     
  Branches     2824     2824              
==========================================
+ Hits        15808    15829      +21     
+ Misses       4785     4784       -1     
  Partials     1122     1122              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pmachapman
pmachapman force-pushed the remove_percent_completed branch 2 times, most recently from f6e700c to 5e0c792 Compare September 30, 2026 20:43

@Enkidu93 Enkidu93 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Enkidu93 reviewed 5 files and all commit messages, and made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on pmachapman).

@Enkidu93
Enkidu93 force-pushed the remove_percent_completed branch from 5e0c792 to 89f53cc Compare October 1, 2026 18:38
@Enkidu93
Enkidu93 merged commit 7ef0d37 into main Oct 1, 2026
1 of 2 checks passed
@Enkidu93
Enkidu93 deleted the remove_percent_completed branch October 1, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove deprecated PercentCompleted

3 participants