Skip to content

Remove deprecated PercentCompleted #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Enkidu93 merged 1 commit into from
Oct 1, 2026
Merged

Remove deprecated PercentCompleted #1055

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions src/Serval/src/Serval.Client/Client.g.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11473,10 +11473,6 @@ public partial class TranslationBuild
[Newtonsoft.Json.JsonProperty("step", Required = Newtonsoft.Json.Required.Always)]
public int Step { get; set; } = default!;

[Newtonsoft.Json.JsonProperty("percentCompleted", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
[System.Obsolete]
public double? PercentCompleted { get; set; } = default!;

[Newtonsoft.Json.JsonProperty("progress", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
public double? Progress { get; set; } = default!;

Expand Down Expand Up @@ -12337,10 +12333,6 @@ public partial class WordAlignmentBuild
[Newtonsoft.Json.JsonProperty("step", Required = Newtonsoft.Json.Required.Always)]
public int Step { get; set; } = default!;

[Newtonsoft.Json.JsonProperty("percentCompleted", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
[System.Obsolete]
public double? PercentCompleted { get; set; } = default!;

[Newtonsoft.Json.JsonProperty("progress", Required = Newtonsoft.Json.Required.Default, NullValueHandling = Newtonsoft.Json.NullValueHandling.Ignore)]
public double? Progress { get; set; } = default!;

Expand Down
3 changes: 0 additions & 3 deletions src/Serval/src/Serval.Translation/Dtos/TranslationBuildDto.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ public record TranslationBuildDto
public IReadOnlyList<TrainingCorpusDto>? TrainOn { get; init; }
public IReadOnlyList<PretranslateCorpusDto>? Pretranslate { get; init; }
public required int Step { get; init; }

[Obsolete]
public double? PercentCompleted { get; init; }
public double? Progress { get; init; }
public string? Message { get; init; }

Expand Down
1 change: 0 additions & 1 deletion src/Serval/src/Serval.Translation/Services/DtoMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ public TranslationBuildDto Map(Build source)
TrainOn = source.TrainOn?.Select(s => Map(source.EngineRef, s)).ToList(),
Pretranslate = source.Pretranslate?.Select(s => Map(source.EngineRef, s)).ToList(),
Step = source.Step,
PercentCompleted = source.Progress,
Progress = source.Progress,
Message = source.Message,
QueueDepth = source.QueueDepth,
Expand Down
3 changes: 0 additions & 3 deletions src/Serval/src/Serval.WordAlignment/Dtos/WordAlignmentBuildDto.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ public record WordAlignmentBuildDto
public IReadOnlyList<TrainingCorpusDto>? TrainOn { get; init; }
public IReadOnlyList<WordAlignmentCorpusDto>? WordAlignOn { get; init; }
public required int Step { get; init; }

[Obsolete]
public double? PercentCompleted { get; init; }
public double? Progress { get; init; }
public string? Message { get; init; }

Expand Down
1 change: 0 additions & 1 deletion src/Serval/src/Serval.WordAlignment/Services/DtoMapper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ public WordAlignmentBuildDto Map(Build source)
TrainOn = source.TrainOn?.Select(s => Map(source.EngineRef, s)).ToList(),
WordAlignOn = source.WordAlignOn?.Select(s => Map(source.EngineRef, s)).ToList(),
Step = source.Step,
PercentCompleted = source.Progress,
Progress = source.Progress,
Message = source.Message,
QueueDepth = source.QueueDepth,
Expand Down
Loading