Repository navigation
Expose typed MCP setup with confirmed save and restart - #37
Merged
Merged
Conversation
|
To use Codex here, create an environment for this repo. |
This was referenced Oct 18, 2026
frahlg
force-pushed
the
codex/mcp-setup-contract
branch
from
October 18, 2026 16:15
e6f7298 to
3ab545c
Compare
frahlg
marked this pull request as ready for review
October 18, 2026 16:15
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Oct 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose setup through seven typed MCP tools: schema, status, draft edit/reset, validation, confirmed save and confirmed restart. The connected box owns the schema, driver catalogue, draft, checks and receipt; Cloud keeps no second configuration model.
Setup write access is an explicit owner choice. Full setup reads use the existing diagnostic scope. Tool security schemes and authentication challenges preserve existing read scopes when a client requests setup. Refused scope widening during refresh no longer consumes the valid read session. A denied box response is a tool error; a lost mutation reply reports an unknown outcome and directs the client to setup_status and the same receipt.
Paired Core #1732 and web client #99 are merged. The protocol pin names their exact Core head a17455aa. Native client #92 is paired.
History dependency #29 merged first. This branch contains only setup changes above that dependency.
Validation: vet, the full race suite, dev-tag suite and import checks passed. OAuth/Noise tests cover explicit grants, old read grants, exact numbers, HTTP failures, authentication metadata, preserved read scopes, and lost save/restart replies. The real consent template was rendered and inspected in a closed local browser fixture. The affected MCP/OAuth/key suites also passed with race checking against the published pin and go.work disabled. A fixed test clock keeps the burst-limit check independent of tool-list transfer time without changing its limits.
Runtime Go growth: internal/mcp +126 lines; internal/oauth +10 lines. No new key service or data storage layer.
This does not claim new-box onboarding, vendor sign-in, invitation redemption, directory listing or physical equipment verification. Keep deployment after the paired Core release is selected.