Repository navigation
fix(platform): report automation history read failures - #4258
Conversation
Independent review — ACCEPT (code and targeted jsdom scope)PR #4258 / TALE-166 / #3621, exact head Observed evidence
Unrun / limitsNo browser, real network outage/recovery, visual layout/contrast/visible-focus/phone-wrapping, or full-stack proof; AUTO-B12 remains unexecuted. Hook results and router links are fixtures, so the jsdom proof establishes rendered state, callback invocation and focus, not live transport recovery. No whole suites, workspace typecheck, lint/format/manual gates or SAST rerun; the author's receipts for those checks were read, not independently certified. CI was not rerun, cancelled, waited on or certified green. Acceptance is not merge readiness and does not clear protected task approvals. No push, merge, source repair or task status change. GitHub's authenticated principal is also the PR's author; this comment is the independent ACCEPT record, not a self-issued formal GitHub approval. Evidence retained in TALE-593's delivery box: |
0a600b8 to
2a1c510
Compare
d3c3333 to
1f4c196
Compare
1f4c196 to
da1019d
Compare
da1019d to
f958988
Compare
# Conflicts: # services/platform/app/features/automations/components/automation-runs-tab.tsx
The runs table showed "This automation has not run yet." both while its first page loaded and after its read failed. It now stays loading until the first page answers, shows an announced error with Try again when a read fails before any run arrived, keeps the runs on screen and stops paging when a later page fails, and hands the retry's focus to the Runs heading once the runs arrive.
Main minted AUTO-B21 and AUTO-B22 for run replays and comparisons, so the history read failure box becomes AUTO-B23 and the suite costs 173 boxes.
What changed
reuse
ErrorDisplayCompactand retry only the failed query withrefetch.AutomationVersionPicker,which already handles failed reads. Lock that working behavior and add
alert announcement and retry-focus handoff to both history surfaces.
EN/DE/FR error controls without introducing message keys.
AUTO-B12for live recovery, visible keyboard focus and narrow-layoutwrapping; document the automated/manual split in the coverage reference.
Verification
origin/maind29a3c8fe: the Runs failure regression observesthe successful empty sentence instead of an error/retry. Both successful
empty-history controls and the Versions error/retry control pass there.
across three files, using one worker. Includes failed initial and cached-empty
reads, retry via Enter, successful recovery/focus, pending states, EN/DE/FR
controls and axe checks of the error surface.
oxlint --type-aware --type-check: three files, zero diagnostics.oxfmt --check, manual-layer gate, automationscheck-guide, andgit diff --check: pass.visual/live-network box is added but not claimed executed. CI and independent
exact-head review remain required before merge.
Separate from run-timeline PR #4239; no shared UI, backend or schema changes.
Closes #3621
Current-main rebase
Replayed the previously accepted source
ffcea33a20a3e769218aa7d08ec6c6dc9c496ddaonto maind1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.Maintenance replay: preserves the accepted feature payload on current main 7d178ca. Includes the merged #4649 Knip cleanup and the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), which is still pending native merge on main. The fixed suite inventory keeps its discovery and source/compiled phase guards. Existing feature proof is retained; no fresh full-feature/full-workspace test or hosted-green claim. Native required checks remain mandatory.