Repository navigation
fix(platform): bound retry and worker cleanup - #4643
Merged
Merged
Conversation
yannickmonney
enabled auto-merge
October 9, 2026 10:40
yannickmonney
force-pushed
the
fix/platform-wave4-review
branch
from
October 9, 2026 14:10
6eb171b to
77a5444
Compare
yannickmonney
force-pushed
the
fix/platform-wave4-review
branch
from
October 9, 2026 15:24
77a5444 to
d1a221c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
These are the platform half of the post-merge review of the sandbox wave. I confirmed each finding against the code, and each fix has a test.
task.agent_retrydecision itself is held for the wait (startAfteron the job). No queued run exists meanwhile, the failed run shows its retry pending (it already holds its slot as an armed retry), and every guard is re-checked when the wait ends.RESOURCE_EXHAUSTED_REKICK_DELAY_MS), and the sandbox README and coverage row say "a task run waits 2, 10, then 30 minutes, an automation's agent node 2". Parking an agent node for a longer timed wait would need new cursor state in the stepper; that's out of scope here.Checks
agent-runs.test.tscovers the held retry decision for each attempt.task_input_mirrors.test.tscovers the new bound and the hidden-stale-copies case.lint:manualpass.Current-main rebase
Replayed the previously accepted source
6eb171b4190ab48bdb9f99f233a47d2f128cabc1onto maind1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.Maintenance replay: preserves the accepted feature payload on main fd277c4, including merged #4649, #4650 and #4655. Retains the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), pending native merge on main. The #4282 task-register union, where applicable, retains the accepted feature row and current-main rows. Existing behavioral evidence remains recorded above; no fresh full-feature/full-workspace or hosted-green claim. All seven native required contexts and full merge-group validation remain mandatory.