Repository navigation
fix: restore shared CI contract checks - #4625
Merged
Merged
Conversation
yannickmonney
enabled auto-merge
October 9, 2026 06:26
yannickmonney
force-pushed
the
fix/cli-merge-group-private-helpers
branch
from
October 9, 2026 07:13
239de34 to
00ff538
Compare
yannickmonney
force-pushed
the
fix/cli-merge-group-private-helpers
branch
from
October 9, 2026 07:52
00ff538 to
4b0666b
Compare
yannickmonney
force-pushed
the
fix/cli-merge-group-private-helpers
branch
from
October 9, 2026 08:32
4b0666b to
f84721f
Compare
yannickmonney
disabled auto-merge
October 9, 2026 09:58
yannickmonney
enabled auto-merge
October 9, 2026 09:58
yannickmonney
force-pushed
the
fix/cli-merge-group-private-helpers
branch
from
October 9, 2026 10:28
f84721f to
db8e8fe
Compare
FINISH_PATHS and decideMergeGroup are used only in their own scripts; exported, they failed knip on main and with it every merge group's Knip job.
yannickmonney
force-pushed
the
fix/cli-merge-group-private-helpers
branch
from
October 9, 2026 11:50
47a6688 to
2929b62
Compare
This was referenced Oct 9, 2026
This was referenced Oct 9, 2026
This was referenced Oct 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared CI was failing across PRs on unused exports, outdated task-review assertions, an incomplete CLI module scope and nondeterministic test fixtures. This change restores those contracts and composes them with the seven-workflow cancellation repair now on main.
/proc/self/fd/N/c.txtopens were hashing successfully but escaped the old path-substring counter. All five cases, 19 assertions and settling-time bounds remain; daemon production is unchanged.Validation: the final composition passes 249 policy cases (2210 assertions) plus 43 release-workflow cases (1873 assertions); a distinct reviewer independently reran all 249 policy cases and verified preservation. Whole configured Knip, full CLI types, scoped typed lint, format, SAST, commitlint and conflict guards pass. Twelve prior accepted blobs remain exact; the two composed cancellation helpers differ from main only by unused export demotions. Linux reproduces the original staged counter 4 pass / 1 fail versus repaired 5 pass / 0 fail, with 51 related cases/151 assertions passing and a separate independent five-case run. Prior source fixes retain their separately recorded causal and selected tests.
The hosted workspace failures on #4214, #4260, #4301 and #4643 expose one further stale Docker inventory expectation. The exact read-only
docker pscall now expects the existing eighth egress-label field emitted by production. This adds one test literal; the fake Docker implementation, all 38 assertion call sites, result checks and time bounds remain unchanged. Linux reproduces 15 passes and one failure before the repair, then 16 passes with the same 59 assertions; related listing and create-call suites give 33 distinct passing cases and 102 assertions in total. A distinct reviewer independently reran the 16-case suite. All 62 sandbox production files and the 16 prior accepted repair files remain byte-identical. Full sandbox types, configured typed lint, format, conflict checks, commitlint and applicable SAST rules pass.Root independently ran the complete maintained sandbox unit suite on exact published
d18e9e25e5db55ea677a31dd453363a6cd84a3bd: 1468 tests passed, zero failed, 9912 assertions across 60 files. This used an ephemeral nonroot Linux arm64 Bun 1.4.2 container with read-only source/dependencies, no network or Docker socket; the worktree remained clean and the owned container was removed. The 33 selected cases above are a subset of this full suite, not additional distinct tests. This is local workspace proof, with hosted x64 CI and all other required workflow checks still pending.All seven native checks remain required. Local Linux proof is arm64, not a newly observed hosted x64 CI result. The previous whole-repository check remained non-green because of unrelated timing failures/cancelled work; the passing focused and static gates do not assert a complete repository or release-candidate validation. Cancellation is never validation success, and this PR does not bypass current sources, merge groups, required checks or release gates.