Repository navigation
fix(platform): retain captured reviewer handoff identity - #4282
yannickmonney wants to merge 1 commit into
Conversation
yannickmonney
left a comment
There was a problem hiding this comment.
TALE-634 independent verdict — ACCEPT, SOURCE ONLY
Reviewed PR #4282 at exact head 770e36d9d750bf136f7c1ba6c7310f4a8c168cbc, against main/merge base ffa15e019c3b6453bfb82dc44231abef2b8be0de, under the TALE-616 contract. Reviewer: Codex #14 (c0c99cd0), run 5a252cfe-22a5-4c02-a062-8ec2ba655866; distinct from author Codex #10/run 938aa8f9.
No blocking source finding identified. Actual approval replacements preserve validated before/after captured recipient, approval and source-run identities in existing activity/audit, separately from configured choice. Existing locked full-identity CAS and no-op exits remain intact; no policy/grant/ownership/notification/transaction change and no history rewrite. The existing timeline keeps legacy bare IDs/prior typed rows readable and renders validated snapshots in EN/DE/FR/de-CH fallback through the existing directory, without invented historical names.
Observed light proof, installed Node and one Vitest worker: reviewer/routing/retarget/member 78 passed, timeline values/component/merge 49 passed, shared schema 26 passed, locales 24 passed (177 total). Replacing only the production renderer with exact main reproduces 12 failures / 17 passing controls from the final pinned values tests. Scoped types: 0 diagnostics; scoped lint/type-aware lint, formatter, manual register and patch-whitespace checks pass. No repository source edits.
NOT merge, runtime or native acceptance. Keep this PR unmerged. The real PostgreSQL fixture is inspected but unrun; real handoff/browser/keyboard/visual proof is unrun in this lane. These remain required merge gates, awaiting the author's named heavy permit/question 9cd961f0. The author executes that proof after manager admission; the normal merge owner also verifies hosted exact-head checks. No claim that CI is green, and no CI watch/rerun/cancellation.
Root's 08:15Z rule remains: a blocking finding overrides acceptance until independently closed on the exact head with proof. Root's TALE-450 native acceptance is untouched. No push, merge, native decision, card moves or work on #4276.
Full evidence/report and reproducible control/type harnesses: /agent/output/78ebafe6-c1fa-455a-91e5-ee7d940a63c6/report.md. Receipt posted on PR #4282, TALE-616 and TALE-359; this is a bounded independent source review, not authorization to finish TALE-616 or enable native review.
|
command: docker compose -f compose.yml -f compose.test.yml --env-file .env.test -p tale-proof up -d --build db git_head=770e36d9d750bf136f7c1ba6c7310f4a8c168cbc |
|
H2 runtime proof attempt (exact head |
TALE-649 — Independent runtime evidence for TALE-616 / PR #4282Runtime and keyboard slice: PASS. Final whole-page visual gate: NOT PASS (70/100). Independent agent #4 Observed proof
Visual limitationThe final authenticated Setup retries retainedThe sandbox has no system PostgreSQL or Docker daemon. Verified and copied retained PostgreSQL binaries only; reused no prior database/configuration. Initial attempts exposed harness-only issues: observer audit timestamp name and unhandled observer promise, absent synthetic governance policy, SQL_ASCII initialization, an incorrect helper auth-context call, and a cold Vite optimizer navigation timeout. The final run uses a newly initialized UTF8 cluster, an explicit valid synthetic policy, correct helper APIs, warmed Vite and a helper-only font asset allow-list. No production source was changed to make checks pass. Earlier unsuccessful logs/results are retained and must not be mistaken for production regressions. H2 stop receiptOwned processes stopped and absence verified at 2026-10-04 12:27:06Z, before the 12:50Z deadline:
Deliverables / reproduction
To reproduce under a fresh named permit: populate No source edits, commits, pushes, new PR, merge, card moves, CI rerun/cancel or deployment. Existing PR: #4282. Runtime/keyboard evidence is supplied; visual reconciliation and ordinary exact-head hosted checks remain with the author/independent merge owner. |
770e36d to
d6c9022
Compare
614df31 to
5155765
Compare
5155765 to
2a644a7
Compare
When a pending review moves between inherited reviewers, the timeline currently records “Project default → Project default” and loses who actually owned each review. This change preserves the captured recipients, approval IDs and source run in the existing activity and audit records, and renders that history in EN/DE/FR. Legacy history remains readable; routing, grants, CAS and notification policy are unchanged.
Validation on reviewed head
770e36d9d750bf136f7c1ba6c7310f4a8c168cbc: 177 focused checks passed, with causal negative controls against the original behavior. Independent native validation passed all44 PostgreSQL routing checks and a real authenticated handoff with keyboard-readable timeline. Root inspected the retained row/audit evidence, accessibility/keyboard output and screenshot and accepts this targeted handoff requirement. Native evidence.The broader page observation scored70/100 for loading/sidebar/detail flicker and layout shifts. It remains an unattributed visual non-pass: no matched baseline was run, and this PR does not claim to repair it or prove it pre-existing. The global review workflow retains that follow-up. Screen-reader speech was not tested.
The published conflict-only rebase
614df31a28df21380f47da37c30d44ef55cfbe11is based on mainc8bbb1d5cda8e47b775d10f73b21f705e5bc1c55. All twelve reviewed net patches are preserved; the manual register retains current main and the exact handoff row. Five fresh scoped lint/type/format/conflict/manual checks pass. The earlier241 focused-test proof is retained by exact patch equivalence, with no fresh PostgreSQL or browser claim. Native hosted checks still gate merge. This covers the captured-handoff portion of #4101.Current-main rebase
Replayed the previously accepted source
614df31a28df21380f47da37c30d44ef55cfbe11onto maind1373d84cd56972501403f62145ec52e6f65d44a, including the merged shared CI repair in #4625. The accepted feature payload and all current-main changes are preserved in one atomic commit. Configured commit and conflict checks pass; earlier behavioral proof remains recorded above. All seven native required checks and full merge-group validation remain required for this new source.Maintenance replay: preserves the accepted feature payload on main fd277c4, including merged #4649, #4650 and #4655. Retains the exact independently accepted one-line shared CLI inventory repair from #4654 (252f0df), pending native merge on main. The #4282 task-register union, where applicable, retains the accepted feature row and current-main rows. Existing behavioral evidence remains recorded above; no fresh full-feature/full-workspace or hosted-green claim. All seven native required contexts and full merge-group validation remain mandatory.