Repository navigation
fix(antigravity): show the Gemini 4 Argon quota group separately - #7283
Conversation
retrieveUserQuotaSummary reports Gemini 4 Argon as its own group. The summary parser matched it as "gemini", so its weekly bucket collided with Gem (Weekly) and was dropped, or replaced the Gemini reading when the Argon group came first. The model-list fallback had the same order problem. Each bucket now decides its family from its own id and name (Argon before Gemini), with the group display name only as a fallback. Argon buckets become Argon / Argon (Weekly) windows tagged with the canonical pool model gemini-4-argon, which keeps them out of headroom, exhaustion, reset ordering and reset notifications like the existing model rows. The account reset-time selection now skips model-attributed rows as well. Closes #7272
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
✅ READY
Hygiene✅ Deterministic PR hygiene checks passed. |
|
Warning Review limit reachedYou've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Next included review available in 28 minutes. View limit details
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
|
Maintainer integration into dev (MAINTAINERS.md exception, actor lidge-jun, admin). This is maintainer integration, not an independent review or self-approval. Exact head: 0b41da7 (contains origin/dev 688b258) Workflow runs at this head:
Decision record:
|
Summary
Antigravity's
retrieveUserQuotaSummarynow returns a dedicated Gemini 4 Argon group, and OpenCodex never showed it. The parser matched the group as "gemini", so its weekly bucket collided withGem (Weekly)and was dropped. When the Argon group came first, it replaced the Gemini reading instead. ThefetchAvailableModelsfallback had the same ordering problem withgemini-4-argon-*models.Argon(5h) andArgon (Weekly)windows taggedmodelId: "gemini-4-argon". The tag uses the existing contract that model-attributed windows are display evidence only, so Argon does not change Gem/Cla headroom, provider exhaustion, reset ordering or reset notifications.accountResetTimestampnow skips model-attributed rows, so a diagnostic row can never become the account's reset time for a family-less request. This is the same one-line filter as in fix(antigravity): show CLI-only Argon quota without duplicate effort rows #7245.With the issue's payload, the report goes from
Gem, Gem (Weekly), Cla, Cla (Weekly)to the same four windows plusArgon (Weekly).Display tradeoffs: like other diagnostic rows, the Argon window gets normal severity in the GUI and is not picked as a headline. An Argon-only summary (no Gemini group) therefore has no compact summary row, though detail views, CLI and management DTOs still show it. The Rust tray minimum includes it, as it already does for fallback model rows.
Out of scope, follow-up: Argon routing still uses the Gemini window, because
classifyModelFamilyForQuotamapsgemini-4-argontogem. Judging Argon requests by their own pool is a separate routing decision.Interaction with #7245 (draft, same file): with this change the summary already includes a
gemini-4-argonmodel-attributed window, so #7245's optional CLI supplement skips itself on summary success. #7245's "IDE Argon ladder" test expects{label: "Gem", percent: 80}from an Argon-first model list. That expectation changes here, so whichever PR lands second has to reconcile it and test the combined tree, including that an untaggedgemini-4-argonlabel does not suppress the supplement.Closes #7272
Verification
Bun 1.4.3, repository runner (
scripts/test.tsisolation), synthetic credentials and injected pinned transports only:bun scripts/test.ts tests/providers/provider-antigravity-model-quota.test.ts tests/providers/provider-quota.test.ts tests/oauth/oauth-account-quota-rank.test.ts tests/providers/provider-antigravity-quota-retry.test.ts tests/providers/provider-account-quota.test.ts: 291 pass, 0 fail.provider-antigravity-model-quota.test.tscover both group orders; 5h, weekly, unsupported-cadence, malformed and duplicate buckets; bucket-versus-group precedence (Claude bucket under an Argon group, Gemini bucket under a Claude group, inconclusive bucket,argonautboundary); the fallback; routing isolation for an exhausted Argon pool (headroom,cachedProviderQuotaIsExhausted, reset observations, reset time); and an Argon-only summary. Driven red once: with the three source files restored toorigin/dev, those 7 fail and the 10 existing tests pass.bun run typecheck: exit 0.bun run structure:check: exit 0.bun run privacy:scan: exit 0.bun scripts/test.ts tests/ci-workflows/file-size-ratchet.test.ts tests/test-layout.test.ts tests/ci-workflows/structure-ssot.test.ts: 62 pass, 0 fail.bun run test: not run locally (documented resource exception). Eleven concurrent worktrees on this machine share the repository runner's user-wide test lock; the full run queued behind another worktree's suite for more than 30 minutes and was stopped. The full suite ran in hosted CI at this exact head:test 1/4totest 4/4all succeeded atfea2fdbbc11eec5eed38d99d2a9b17eb8514b37e.Checklist