Repository navigation
Conversation
|
Warning Review limit reached
This review includes 12 billable files and costs up to $3.00.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 3 minutes for your next included review. View limit details
|
|
Agent review and exercised workflow: the implementation now subscribes to bounded, current agent channel memberships. It derives the history fence after the live subscription is installed and accepts acknowledgements of its own closed discovery/history subscriptions. The production listener regression fails if the close-ack guard is removed; the fake relay now models Buzz's channel-only live routing. Cross-owner wakeup runs the same fresh policy and durable budget admission as running turns, then constructs an immutable target-owner launch without forging an owner signature. The manager still uses configured namespaces, saved launch credentials, image policy, and quotas. Refused starts retain a signed channel notice. Per-agent discovery is bounded at 64 channels and uses the agent's own relay identity. The complete local workflow passed with a real relay, Postgres/Redis, actual harness processes and CLI commands: another human invokes a sleeping shared agent, that agent hands off to another owner's agent, the response stays in the original thread, and revocation prevents another model turn. The ACP model adapter and Kubernetes API were simulated; this is not staging or external-model evidence. Manager: 140 tests passed; Kubernetes provider: 223 unit and 5 integration tests passed. Two manager tests and one provider test require separate infrastructure; the new real-relay test was run explicitly and passed. Clippy passed across all targets for both packages, as did formatting and the repository file-size gate. No remaining concrete blocker found in this layer. Minimalism, elegance, correctness: 9/10 each. Human acceptance and staging rollout remain pending. |
Signed-off-by: Tee8z <tee8z@protonmail.com>
3a10d9d to
6e9dcd7
Compare
An ordinary channel mention could reach history but fail to wake a sleeping remote agent live. The wake listener subscribed without channel scope and treated its own history-close acknowledgement as an error. This layer discovers up to 64 current agent channel memberships, subscribes explicitly to those channels, overlaps history with the installed live subscription, and accepts requested close acknowledgements.
With the manager's
shared_taskssetting enabled, cross-owner mentions use the same current-grant policy and atomic admission journal as running harness turns. A verified shared task constructs a confined launch in the target owner's existing namespace; it never manufactures an owner-signed control event. Permanent refusals produce durable channel replies. Owner lifecycle operations remain separately authorized.Depends on #113. Review order: #108 → #101 → #110 → #112 → #113 → this PR.
Validation:
Rollout remains disabled by default. Deploy matching relay, manager, and agent images, enable mention startup and
shared_tasksin the manager config, then let each human owner publish channel grants. Existing older thread configurations require explicit recovery or a new thread. The infrastructure switch is voltage-terraform #1015. Server startup also needs voltage-terraform #1014 and CD #667. No capacity, Spot policy, IAM, or session quota expansion is included in this sharing layer.Human acceptance remains pending. After rollout, a second channel member should invoke an opted-in agent, hand work to another owner's opted-in agent, and revoke one grant. The next shared turn must visibly refuse; owner DMs and owner lifecycle controls must still work. No review-completion attestation is claimed.