feat(agent-harness): fence retirement and retry payload cleanup - #5667
Closed
iscekic wants to merge 3 commits into
Closed
feat(agent-harness): fence retirement and retry payload cleanup#5667iscekic wants to merge 3 commits into
iscekic wants to merge 3 commits into
Conversation
This was referenced Aug 28, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Reviewed by grok-4.6 · Input: 142.7K · Output: 20.2K · Cached: 484.9K Review guidance: REVIEW.md from base branch |
This was referenced Aug 28, 2026
This was referenced Aug 30, 2026
This was referenced Aug 31, 2026
Contributor
Author
|
Closing: the owner stopped this workflow section. The branch is retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Account and organization deletion call
retireHarnessConversationswithin their transactions, so Worker availability does not decide deletion success.softDeleteUser,anonymizeCloudUserData, andorganizationAdminRouter.deleteretain their caller contracts, subscription guards, response shapes, and error behavior.Organization retirement follows the admission lock order before hierarchy checks; a hierarchy rejection rolls back both retirement and deletion.
Files
apps/web/src/lib/user/index.ts— replaces inline harness cleanup with the shared retirement call; preserves explicit client and user-grant deletion (modified; +2/−37 lines).apps/web/src/routers/organizations/organization-admin-router.ts— adds retirement before hierarchy validation and the organization update inside the existing advisory-locked transaction (modified; +4/−0 lines).The retirement store recovers orphaned conversations and retries purge delivery; permanent fences keep retired generations closed after payload cleanup.
Identity,Claim,Receipt, andBatchLimitrequire matching conversation generations, valid leases, strict durable acknowledgments, and batches of one to ten.HarnessMaintenanceRequestrestricts protocol version 1 topurgeandimportLegacythrough signedPOST /internal/maintenancecalls, without creating primary authority.Files
apps/web/src/lib/agent-harness/retirement.ts— adds transaction-owned fences usingaccount_deletedorcontext_retired; preserves generation zero for unregistered threads. Locks threads by identifier before registry updates and clears owner/context links. Deletes threads, with cascading removal of messages, grants, and invitation results. The sweep removes obsolete clients and catches missing threads, owner/context mismatches, deleted accounts, and missing or deleted organizations. Each sweep category skips locked rows and handles at most ten records. Purge claims use 60-second leases and one delivery attempt per lease; only matchingdurable: truereceipts acknowledge a current lease. Acknowledgment removes discovery rows but retains the permanent fence; failures and lost acknowledgments retry after expiry. Transport binds HS256 tokens to issuer, audience, 60-second expiry, operation, identity, dispatch identifier, and the body digest, plus service authentication. It requires HTTPS except on loopback, rejects URL credentials and redirects, and enforces a two-second timeout and 4,096-byte JSON receipts (added; +282/−0 lines).GET /api/cron/agent-harness-cleanupadds authenticated, one-minute maintenance with a 60-second execution limit and ten-item batches.CRON_SECRETauthorizes calls;AGENT_HARNESS_API_URL,NEXTAUTH_SECRET, andINTERNAL_API_SECRETconfigure delivery to the level-22 Worker receiver.The response reports
success,swept,purge, andingressresults; absent delivery configuration leaves remote work pending without blocking transactional deletion.Files
apps/web/src/app/api/cron/agent-harness-cleanup/route.ts— adds a GET handler that rejects missing or invalid cron credentials with 401. Runs the orphan sweep, purge delivery, and leased legacy ingress for registered conversations in that order. Returns purge acknowledgment/retry counts and ingress acknowledgment/retry/rejection counts (added; +46/−0 lines).apps/web/vercel.json— schedules the cleanup route every minute without changing the existing cron entries (modified; +4/−0 lines).Tests: 2 files changed —
apps/web/src/lib/agent-harness/retirement.test.tsadded (+1,037/−0 lines);apps/web/src/lib/user/index.test.tsmodified (+25/−2 lines).Generated: 0 files changed.
Visual Changes
Visual Changes: N/A
Verification
No manual runtime verification ran for this level. Isolated PostgreSQL inputs remain unavailable, and the real Worker receiver belongs to level 22.
Reviewer Notes
Human steps
CRON_SECRET,NEXTAUTH_SECRET, andINTERNAL_API_SECRETexist in the target web deployment. If a value is missing, runpnpm web:env set <VARIABLE>.pnpm web:env set AGENT_HARNESS_API_URLto select that receiver.Recorded checks
Scope
Kilo-Org/cloud./Users/igor/Projects/.worktrees/shared-agent-harness-3bb0.shared-agent-harness-3bb0-s8toshared-agent-harness-3bb0-s9.Notes
No manual runtime verification ran for this level. Full backend, browser, iOS, and Android verification remains required on the completed stack tip.
Real PostgreSQL tests remain required in CI. Local pure tests do not prove database race behavior or actual Worker durability.
Stacked PRs — merge bottom to top. Each level shows only its own diff.
Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.
shared-agent-harness-3bb0— chore(agent-harness): register workspaces and enforce CI boundaries #5632shared-agent-harness-3bb0-s2— feat(agent-harness): define portable domain and snapshots #5637shared-agent-harness-3bb0-s3— feat(agent-harness): define commands tools and permission policy #5639shared-agent-harness-3bb0-s4— feat(agent-harness): share client state and cursor recovery #5643shared-agent-harness-3bb0-s5— feat(agent-harness): persist command intents and execution receipts #5647shared-agent-harness-3bb0-s6— feat(db): add harness ingress grants and retirement fences #5655shared-agent-harness-3bb0-s7— feat(agent-harness): deliver legacy history and project durable text #5659shared-agent-harness-3bb0-s8— feat(agent-harness): authorize durable grants and registered clients #5662shared-agent-harness-3bb0-s9— feat(agent-harness): fence retirement and retry payload cleanup #5667 ← this PRshared-agent-harness-3bb0-s10— feat(agent-harness): persist authoritative state in SQLite #5675shared-agent-harness-3bb0-s11— feat(agent-harness): admit durable runs and revisioned commands #5678shared-agent-harness-3bb0-s12— feat(agent-harness): recover queued runs and stream checkpointed steps #5688shared-agent-harness-3bb0-s13— feat(agent-harness): resolve interactions and dispatch tools sequentially #5693shared-agent-harness-3bb0-s14— feat(agent-harness): fence designated client tool execution #5697shared-agent-harness-3bb0-s15— feat(agent-harness): synchronize durable snapshots and legacy history #5701shared-agent-harness-3bb0-s16— feat(agent-harness): reuse authorized invitations with durable replay #5704shared-agent-harness-3bb0-s17— feat(integrations): bound repository transport for harness reads #5710shared-agent-harness-3bb0-s18— feat(integrations): expose bounded authorized repository reads #5714shared-agent-harness-3bb0-s19— feat(agent-harness): expose named authorized resource reads #5718shared-agent-harness-3bb0-s20— feat(sessions): bound history transport for harness reads #5724shared-agent-harness-3bb0-s21— feat(agent-harness): read scoped Cloud Agent context and progress #5726shared-agent-harness-3bb0-s22— fix(agent-harness): preserve ordered Cloud Agent dispatch identity #5731shared-agent-harness-3bb0-s23— feat(agent-harness): hand coding work to authorized Cloud Agent sessions #5733shared-agent-harness-3bb0-s24— feat(agent-harness): authorize scoped MCP gateway connections #5737shared-agent-harness-3bb0-s25— feat(agent-harness): bound MCP gateway transport in the Worker #5740shared-agent-harness-3bb0-s26— feat(agent-harness): execute validated remote MCP tools #5743shared-agent-harness-3bb0-s27— refactor(exa): share provider dispatch and usage recording #5746shared-agent-harness-3bb0-s28— feat(agent-harness): authorize bounded web provider requests #5747shared-agent-harness-3bb0-s29— feat(agent-harness): normalize web sources and preserve citations #5749shared-agent-harness-3bb0-s30— feat(agent-harness): define closed internal operation contracts #5753shared-agent-harness-3bb0-s31— feat(agent-harness): authorize internal maintenance operations #5754shared-agent-harness-3bb0-s32— feat(agent-harness): authorize named Kilo operation dispatch #5755shared-agent-harness-3bb0-s33— feat(agent-harness): authorize internal provider operations #5757shared-agent-harness-3bb0-s34— feat(agent-harness): secure the internal operations endpoint #5758shared-agent-harness-3bb0-s35— feat(agent-harness): bound and sanitize model streams #5767shared-agent-harness-3bb0-s36— feat(agent-harness): secure billed model inference #5776shared-agent-harness-3bb0-s37— test(agent-harness): cover model gateway security boundaries #5777 (tip)