feat(agent-harness): secure the internal operations endpoint - #5758
Closed
iscekic wants to merge 2 commits into
Closed
feat(agent-harness): secure the internal operations endpoint#5758iscekic wants to merge 2 commits into
iscekic wants to merge 2 commits into
Conversation
This was referenced Aug 31, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by grok-4.6 · Input: 139.5K · Output: 26.3K · Cached: 456.8K Review guidance: REVIEW.md from base branch |
This was referenced Aug 31, 2026
This was referenced Aug 31, 2026
This was referenced Aug 31, 2026
Contributor
Author
|
Closing: the owner stopped this workflow section. The branch is retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new behavior — the product's screens and available actions remain unchanged.
Summary
POST /api/internal/agent-harness/operationsrequiresx-internal-api-keyto match the existingINTERNAL_API_SECRETand a signedAuthorization: Bearercapability.It enforces 65,536-byte requests, 1,048,576-byte complete replies,
cache-control: no-store, and a 60-secondmaxDurationto bound transport without caching authority-sensitive results.On overflow, web replies retain actual nullable
costMicrodollarsin a sanitized, non-retryablelimit_exceededresult, even during cancellation races.Files
apps/web/src/app/api/internal/agent-harness/operations/route.ts— Added source (+76/−0 lines). Compares service secrets in constant time and rejects missing or malformed bearer credentials before reading the body. Requires JavaScript Object Notation (JSON) bodies and rejects malformed 8-bit Unicode Transformation Format (UTF-8) encoding. Counts streamed bytes before parsing, then cancels and releases the body reader. Measures the complete serialized reply, including its envelope, and sends the checked string withapplication/jsonandno-storeheaders. Accepts exactly 1,048,576 bytes; larger web replies retain null, zero, or positive cost in a smallstatus: failedresult with status 200. Other reply overflow returns status 400. Service authentication failures and missing bearer credentials return 401. Operation errors use 403 foraccess_revoked, 503 when retryable, and 400 otherwise; result envelopes return 200. Forwards the request's cancellation signal to execution.apps/web/src/lib/agent-harness/internal.test.ts— Added test (+516/−0 lines). Covers service and capability authentication, authority loss, signed request tampering, malformed or oversized bodies, output validation, connection redaction, empty results, and sanitized recovery. Exercises dispatch identity, legacy reconciliation, lost invitation outcomes, reservation binding, cancellation, history, projection, and fenced retirement. Checks exact-limit and one-byte-over web responses with null, zero, and positive costs, including cancellation races and actual response bytes.The server-only
executeHarnessOperationappliesHarnessOperationSchemato routeexecute,reconcile,read,history,projection, andretirementthrough existing helpers.This preserves current primary authority, signed input digests, immutable
dispatchStartedAt, and matching web reservations without exposing arbitrary procedure names.Legacy reconciliation keeps an absent
dispatchStartedAtexplicit, and uncertain mutations retainoutcome_unknowninstead of claiming cancellation or success.Files
apps/web/src/lib/agent-harness/operations.ts— Added source (+36/−0 lines). Validates and bounds input before routing authority reads, history delivery, text projection, and retirement to their existing helpers. Routes Model Context Protocol (MCP) operationsmcp.discoverandmcp.call, plusweb.searchandweb.retrieve, to provider helpers. Sends other allowed execution and reconciliation requests to the dispatch helper, retaining named preconditions and primary authorization checks. Preserves original dispatch timestamps and digests; new cloud mutations still require a timestamp, while legacy reconciliation keeps its absence. Retains signed reservation checks for the operation, run, call, and original deadline rather than creating a replacement reservation. Keeps retirement tied to the exact signed purge and matching primary generation fence, without requiring a live grant. Passes cancellation through execution and reconciliation, preserves validated outputs, and re-exportsharnessOperationFailurefor shared sanitized errors and outer failures.Tests: 1 test file added —
internal.test.ts(+516/−0 lines).Generated: 0 files changed.
Verification
Manual verification: not run because the endpoint does not yet connect to a complete product journey.
Worker composition, billed model inference, live providers, presentation, and cross-client verification remain later planned work.
Visual Changes
Visual Changes: N/A
Reviewer Notes
Human steps
This level requires no human setup before or after merge.
Product pull request merges remain human-owned.
Recorded checks
Notes
Stacked PRs — merge bottom to top. Each level shows only its own diff.
Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.
shared-agent-harness-3bb0— chore(agent-harness): register workspaces and enforce CI boundaries #5632shared-agent-harness-3bb0-s2— feat(agent-harness): define portable domain and snapshots #5637shared-agent-harness-3bb0-s3— feat(agent-harness): define commands tools and permission policy #5639shared-agent-harness-3bb0-s4— feat(agent-harness): share client state and cursor recovery #5643shared-agent-harness-3bb0-s5— feat(agent-harness): persist command intents and execution receipts #5647shared-agent-harness-3bb0-s6— feat(db): add harness ingress grants and retirement fences #5655shared-agent-harness-3bb0-s7— feat(agent-harness): deliver legacy history and project durable text #5659shared-agent-harness-3bb0-s8— feat(agent-harness): authorize durable grants and registered clients #5662shared-agent-harness-3bb0-s9— feat(agent-harness): fence retirement and retry payload cleanup #5667shared-agent-harness-3bb0-s10— feat(agent-harness): persist authoritative state in SQLite #5675shared-agent-harness-3bb0-s11— feat(agent-harness): admit durable runs and revisioned commands #5678shared-agent-harness-3bb0-s12— feat(agent-harness): recover queued runs and stream checkpointed steps #5688shared-agent-harness-3bb0-s13— feat(agent-harness): resolve interactions and dispatch tools sequentially #5693shared-agent-harness-3bb0-s14— feat(agent-harness): fence designated client tool execution #5697shared-agent-harness-3bb0-s15— feat(agent-harness): synchronize durable snapshots and legacy history #5701shared-agent-harness-3bb0-s16— feat(agent-harness): reuse authorized invitations with durable replay #5704shared-agent-harness-3bb0-s17— feat(integrations): bound repository transport for harness reads #5710shared-agent-harness-3bb0-s18— feat(integrations): expose bounded authorized repository reads #5714shared-agent-harness-3bb0-s19— feat(agent-harness): expose named authorized resource reads #5718shared-agent-harness-3bb0-s20— feat(sessions): bound history transport for harness reads #5724shared-agent-harness-3bb0-s21— feat(agent-harness): read scoped Cloud Agent context and progress #5726shared-agent-harness-3bb0-s22— fix(agent-harness): preserve ordered Cloud Agent dispatch identity #5731shared-agent-harness-3bb0-s23— feat(agent-harness): hand coding work to authorized Cloud Agent sessions #5733shared-agent-harness-3bb0-s24— feat(agent-harness): authorize scoped MCP gateway connections #5737shared-agent-harness-3bb0-s25— feat(agent-harness): bound MCP gateway transport in the Worker #5740shared-agent-harness-3bb0-s26— feat(agent-harness): execute validated remote MCP tools #5743shared-agent-harness-3bb0-s27— refactor(exa): share provider dispatch and usage recording #5746shared-agent-harness-3bb0-s28— feat(agent-harness): authorize bounded web provider requests #5747shared-agent-harness-3bb0-s29— feat(agent-harness): normalize web sources and preserve citations #5749shared-agent-harness-3bb0-s30— feat(agent-harness): define closed internal operation contracts #5753shared-agent-harness-3bb0-s31— feat(agent-harness): authorize internal maintenance operations #5754shared-agent-harness-3bb0-s32— feat(agent-harness): authorize named Kilo operation dispatch #5755shared-agent-harness-3bb0-s33— feat(agent-harness): authorize internal provider operations #5757shared-agent-harness-3bb0-s34— feat(agent-harness): secure the internal operations endpoint #5758 ← this PRshared-agent-harness-3bb0-s35— feat(agent-harness): bound and sanitize model streams #5767shared-agent-harness-3bb0-s36— feat(agent-harness): secure billed model inference #5776shared-agent-harness-3bb0-s37— test(agent-harness): cover model gateway security boundaries #5777 (tip)