feat(sessions): bound history transport for harness reads - #5724
Closed
iscekic wants to merge 3 commits into
Closed
Conversation
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
Reviewed by grok-4.6 · Input: 277.7K · Output: 16.1K · Cached: 527.4K Review guidance: REVIEW.md from base branch |
This was referenced Aug 29, 2026
This was referenced Aug 30, 2026
This was referenced Aug 31, 2026
Contributor
Author
|
Closing: the owner stopped this workflow section. The branch is retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new behavior — current session history views do not enable the new optional limits.
Summary
fetchSessionMessagesPageadds optionalSessionMessagesPageOptions.bounded, reusing a fixed 1 mebibyte (MiB) response limit and 30-second transport deadline.Both success and error bodies face byte limits before decoding; the shared reader validates
Content-Length, streamed bytes, encoding, andapplication/jsonsuccess bodies.The reader cancels unfinished streams; bounded status and validation errors omit upstream details, while omitted or
falseoptions preserve legacy transport and reporting.Files
apps/web/src/lib/session-ingest-client.ts— source, modified; 30 changed lines. SendsAccept: application/json, the existing authorization token, and an abort signal without changing pagination query parameters. RequiresContent-Type: application/jsonfor successful bodies and validutf-8, while enforcing declared and streamed byte counts. A404returnsnullafter the bounded read completes; nullable history and typed worker outcomes retain their existing shape. Other status failures include only the status code; malformed data produces a generic error without validation details or client-sidecaptureExceptioncalls.GetSessionMessagesPageInputSchemaadds optional booleanboundedtogetSessionMessagesPage, retaining ownership, organization access, cursor validation, the 50-message default, and the 100-message maximum.Bounded requests skip the optional watermark query and return
watermarkEventId: null; this avoids an extra service call but does not seed event replay.For bounded failures,
INTERNAL_SERVER_ERRORkeeps its stable message without console logging or the upstream cause; omitted orfalsepreserves legacy errors and watermarks.Files
apps/web/src/routers/cli-sessions-v2-router.ts— source, modified; 24 changed lines. Forwardsboundedonly when supplied, preserves thecursor-to-beforemapping, and keeps the shared access check before transport. Skips the Cloud Agent watermark read for bounded calls and removes upstream causes to keep response bodies and credentials out of Sentry. Workernullstill becomesNOT_FOUND, and results still includewatermarkEventId.Tests: 2 files modified —
apps/web/src/lib/session-ingest-client.test.ts(187 changed lines) andapps/web/src/routers/cli-sessions-v2-router.test.ts(151 changed lines), covering bounded reads and legacy compatibility.Generated: 0 files changed.
Verification
No manual tests ran because this level adds bounded history transport without activating the harness.
Harness opt-in, composition, presentation, and live proof remain in later slices.
Visual Changes
Visual Changes: N/A
Reviewer Notes
shared-agent-harness-3bb0-s19andshared-agent-harness-3bb0-s20.Kilo-Org/cloud; worktree:/Users/igor/Projects/.worktrees/shared-agent-harness-3bb0.Human steps
This change requires no human steps before merge or after merge.
Notes
Runtime verification remains pending at the stack tip. This level adds bounded history transport without activating the harness.
Stacked PRs — merge bottom to top. Each level shows only its own diff.
Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.
shared-agent-harness-3bb0— chore(agent-harness): register workspaces and enforce CI boundaries #5632shared-agent-harness-3bb0-s2— feat(agent-harness): define portable domain and snapshots #5637shared-agent-harness-3bb0-s3— feat(agent-harness): define commands tools and permission policy #5639shared-agent-harness-3bb0-s4— feat(agent-harness): share client state and cursor recovery #5643shared-agent-harness-3bb0-s5— feat(agent-harness): persist command intents and execution receipts #5647shared-agent-harness-3bb0-s6— feat(db): add harness ingress grants and retirement fences #5655shared-agent-harness-3bb0-s7— feat(agent-harness): deliver legacy history and project durable text #5659shared-agent-harness-3bb0-s8— feat(agent-harness): authorize durable grants and registered clients #5662shared-agent-harness-3bb0-s9— feat(agent-harness): fence retirement and retry payload cleanup #5667shared-agent-harness-3bb0-s10— feat(agent-harness): persist authoritative state in SQLite #5675shared-agent-harness-3bb0-s11— feat(agent-harness): admit durable runs and revisioned commands #5678shared-agent-harness-3bb0-s12— feat(agent-harness): recover queued runs and stream checkpointed steps #5688shared-agent-harness-3bb0-s13— feat(agent-harness): resolve interactions and dispatch tools sequentially #5693shared-agent-harness-3bb0-s14— feat(agent-harness): fence designated client tool execution #5697shared-agent-harness-3bb0-s15— feat(agent-harness): synchronize durable snapshots and legacy history #5701shared-agent-harness-3bb0-s16— feat(agent-harness): reuse authorized invitations with durable replay #5704shared-agent-harness-3bb0-s17— feat(integrations): bound repository transport for harness reads #5710shared-agent-harness-3bb0-s18— feat(integrations): expose bounded authorized repository reads #5714shared-agent-harness-3bb0-s19— feat(agent-harness): expose named authorized resource reads #5718shared-agent-harness-3bb0-s20— feat(sessions): bound history transport for harness reads #5724 ← this PRshared-agent-harness-3bb0-s21— feat(agent-harness): read scoped Cloud Agent context and progress #5726shared-agent-harness-3bb0-s22— fix(agent-harness): preserve ordered Cloud Agent dispatch identity #5731shared-agent-harness-3bb0-s23— feat(agent-harness): hand coding work to authorized Cloud Agent sessions #5733shared-agent-harness-3bb0-s24— feat(agent-harness): authorize scoped MCP gateway connections #5737shared-agent-harness-3bb0-s25— feat(agent-harness): bound MCP gateway transport in the Worker #5740shared-agent-harness-3bb0-s26— feat(agent-harness): execute validated remote MCP tools #5743shared-agent-harness-3bb0-s27— refactor(exa): share provider dispatch and usage recording #5746shared-agent-harness-3bb0-s28— feat(agent-harness): authorize bounded web provider requests #5747shared-agent-harness-3bb0-s29— feat(agent-harness): normalize web sources and preserve citations #5749shared-agent-harness-3bb0-s30— feat(agent-harness): define closed internal operation contracts #5753shared-agent-harness-3bb0-s31— feat(agent-harness): authorize internal maintenance operations #5754shared-agent-harness-3bb0-s32— feat(agent-harness): authorize named Kilo operation dispatch #5755shared-agent-harness-3bb0-s33— feat(agent-harness): authorize internal provider operations #5757shared-agent-harness-3bb0-s34— feat(agent-harness): secure the internal operations endpoint #5758shared-agent-harness-3bb0-s35— feat(agent-harness): bound and sanitize model streams #5767shared-agent-harness-3bb0-s36— feat(agent-harness): secure billed model inference #5776shared-agent-harness-3bb0-s37— test(agent-harness): cover model gateway security boundaries #5777 (tip)