Skip to content

feat(agent-harness): authorize internal maintenance operations - #5754

Closed
iscekic wants to merge 2 commits into
shared-agent-harness-3bb0-s30from
shared-agent-harness-3bb0-s31
Closed

feat(agent-harness): authorize internal maintenance operations#5754
iscekic wants to merge 2 commits into
shared-agent-harness-3bb0-s30from
shared-agent-harness-3bb0-s31

Conversation

@iscekic

@iscekic iscekic commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

No new behavior — These maintenance operations are not active in the product.


Summary

executeHarnessMaintenance implements HarnessOperation reads, history imports, and text projection behind fresh primary authority and request-bound capabilities, preventing access through stale grants.
history requires matching durable receipts before acknowledging signed importLegacy deliveries; projection binds the conversation, message key, and returned identifier.
retirement authorizes signed purge requests only against matching agent_harness_retirements fences, allowing deleted accounts without live grants and leaving stored data unchanged.

Files
  • apps/web/src/lib/agent-harness/operation-maintenance.ts — Added source (+138/−0 lines). Returns strictly validated, bounded QuickChatAuthoritySchema data for read. Bounds input and history output, validates delivery identifiers and requested counts, and restricts delivery statuses to acknowledged, retry, or rejected. Reports backlog as pending or drained, and rejects mismatched projection keys or result identifiers. Checks HS256 signatures, strict claims, issuer, audience, request digest, dispatch, thread, generation, and a 60-second maximum before reading the primary retirement fence. Rejects future issue times and expired tokens. Maps late QuickChatAuthorityError failures to FORBIDDEN.
  • apps/web/src/lib/agent-harness/operation-maintenance.test.ts — Added test (+369/−0 lines). Covers personal and organization authority, revocation, substituted scope and ownership, history progress, projection binding, byte limits, malformed output, sanitized failures, and retirement fences. Exercises the actual sender and acknowledgment callback with fake primary storage and transport. Verifies the fixed route, request headers, signature, body digest, message-based dispatch identity, and timestamp normalization. Keeps history pending until a matching durable receipt, including invalid-receipt and transport-failure cases.

Tests: 1 test file added — operation-maintenance.test.ts (+369/−0 lines).
Generated: 0 files changed.


Visual Changes

Visual Changes: N/A

Verification

Manual verification: not run because no endpoint activates at this level.
The evidence does not establish actual PostgreSQL execution or deployed runtime behavior.

Reviewer Notes

Human steps

None before or after merge. This level adds no new required setting, secret, migration, flag, or deployment order.

Recorded checks

  • The handoff reports 59 passing tests and passing scoped lint, format, and whitespace checks.
  • This description round did not rerun the product checks.
  • Full checks and actual PostgreSQL execution remain with continuous integration (CI).

Scope

  • Repository: Kilo-Org/cloud; worktree: /Users/igor/Projects/.worktrees/shared-agent-harness-3bb0.
  • Review range: shared-agent-harness-3bb0-s30...shared-agent-harness-3bb0-s31.
  • This level does not add named dispatch, provider operations, or endpoint composition.

Notes

Runtime verification remains pending at the stack tip. This level adds authorized maintenance operations without activating an endpoint.

Stacked PRs — merge bottom to top. Each level shows only its own diff.

Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.

  1. shared-agent-harness-3bb0chore(agent-harness): register workspaces and enforce CI boundaries #5632
  2. shared-agent-harness-3bb0-s2feat(agent-harness): define portable domain and snapshots #5637
  3. shared-agent-harness-3bb0-s3feat(agent-harness): define commands tools and permission policy #5639
  4. shared-agent-harness-3bb0-s4feat(agent-harness): share client state and cursor recovery #5643
  5. shared-agent-harness-3bb0-s5feat(agent-harness): persist command intents and execution receipts #5647
  6. shared-agent-harness-3bb0-s6feat(db): add harness ingress grants and retirement fences #5655
  7. shared-agent-harness-3bb0-s7feat(agent-harness): deliver legacy history and project durable text #5659
  8. shared-agent-harness-3bb0-s8feat(agent-harness): authorize durable grants and registered clients #5662
  9. shared-agent-harness-3bb0-s9feat(agent-harness): fence retirement and retry payload cleanup #5667
  10. shared-agent-harness-3bb0-s10feat(agent-harness): persist authoritative state in SQLite #5675
  11. shared-agent-harness-3bb0-s11feat(agent-harness): admit durable runs and revisioned commands #5678
  12. shared-agent-harness-3bb0-s12feat(agent-harness): recover queued runs and stream checkpointed steps #5688
  13. shared-agent-harness-3bb0-s13feat(agent-harness): resolve interactions and dispatch tools sequentially #5693
  14. shared-agent-harness-3bb0-s14feat(agent-harness): fence designated client tool execution #5697
  15. shared-agent-harness-3bb0-s15feat(agent-harness): synchronize durable snapshots and legacy history #5701
  16. shared-agent-harness-3bb0-s16feat(agent-harness): reuse authorized invitations with durable replay #5704
  17. shared-agent-harness-3bb0-s17feat(integrations): bound repository transport for harness reads #5710
  18. shared-agent-harness-3bb0-s18feat(integrations): expose bounded authorized repository reads #5714
  19. shared-agent-harness-3bb0-s19feat(agent-harness): expose named authorized resource reads #5718
  20. shared-agent-harness-3bb0-s20feat(sessions): bound history transport for harness reads #5724
  21. shared-agent-harness-3bb0-s21feat(agent-harness): read scoped Cloud Agent context and progress #5726
  22. shared-agent-harness-3bb0-s22fix(agent-harness): preserve ordered Cloud Agent dispatch identity #5731
  23. shared-agent-harness-3bb0-s23feat(agent-harness): hand coding work to authorized Cloud Agent sessions #5733
  24. shared-agent-harness-3bb0-s24feat(agent-harness): authorize scoped MCP gateway connections #5737
  25. shared-agent-harness-3bb0-s25feat(agent-harness): bound MCP gateway transport in the Worker #5740
  26. shared-agent-harness-3bb0-s26feat(agent-harness): execute validated remote MCP tools #5743
  27. shared-agent-harness-3bb0-s27refactor(exa): share provider dispatch and usage recording #5746
  28. shared-agent-harness-3bb0-s28feat(agent-harness): authorize bounded web provider requests #5747
  29. shared-agent-harness-3bb0-s29feat(agent-harness): normalize web sources and preserve citations #5749
  30. shared-agent-harness-3bb0-s30feat(agent-harness): define closed internal operation contracts #5753
  31. shared-agent-harness-3bb0-s31feat(agent-harness): authorize internal maintenance operations #5754 ← this PR
  32. shared-agent-harness-3bb0-s32feat(agent-harness): authorize named Kilo operation dispatch #5755
  33. shared-agent-harness-3bb0-s33feat(agent-harness): authorize internal provider operations #5757
  34. shared-agent-harness-3bb0-s34feat(agent-harness): secure the internal operations endpoint #5758
  35. shared-agent-harness-3bb0-s35feat(agent-harness): bound and sanitize model streams #5767
  36. shared-agent-harness-3bb0-s36feat(agent-harness): secure billed model inference #5776
  37. shared-agent-harness-3bb0-s37test(agent-harness): cover model gateway security boundaries #5777 (tip)

@kilo-code-bot

kilo-code-bot Bot commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (2 files)
  • apps/web/src/lib/agent-harness/operation-maintenance.ts
  • apps/web/src/lib/agent-harness/operation-maintenance.test.ts

Reviewed by grok-4.6 · Input: 323K · Output: 23.2K · Cached: 765.3K

Review guidance: REVIEW.md from base branch shared-agent-harness-3bb0-s30

This was referenced Aug 30, 2026
@iscekic

iscekic commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Closing: the owner stopped this workflow section. The branch is retained.

@iscekic iscekic closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant