fix(agent-harness): preserve ordered Cloud Agent dispatch identity - #5731
Closed
iscekic wants to merge 3 commits into
Closed
fix(agent-harness): preserve ordered Cloud Agent dispatch identity#5731iscekic wants to merge 3 commits into
iscekic wants to merge 3 commits into
Conversation
This was referenced Aug 29, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (5 files)
Reviewed by grok-4.6 · Input: 463.5K · Output: 27.6K · Cached: 1M Review guidance: REVIEW.md from base branch |
This was referenced Aug 30, 2026
This was referenced Aug 30, 2026
This was referenced Aug 31, 2026
Contributor
Author
|
Closing: the owner stopped this workflow section. The branch is retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No new behavior — this change adds internal safeguards without enabling new product features.
Summary
Fresh
SchedulerAdapter.dispatchcalls require numericdispatchStartedAt;SchedulerAdapter.reconciliation.readreceives the original reservation time or explicit legacyundefinedthroughToolExecution.Reconciliation matches the original attempt and call, excludes released reservations, and preserves identity across restarts without substituting the recovery time.
Without that timestamp,
kilo.sessions.*mutations remainoutcome_unknownwithout lookup or redispatch; other adapters retain legacy reconciliation.Files
services/agent-harness/src/scheduler.ts— Source, M (modified), 23 changed lines; passes the original reservation timestamp and guards legacy Cloud Agent reconciliation.services/agent-harness/src/cloud-agent-dispatch.test.ts— Test, A (added), 179 changed lines; checks Durable Object restart recovery, stable dispatch identity, no repeated effects, and legacy reconciliation.InvocationaddsdispatchStartedAt;DispatchTimerequires a nonnegative safe integer for mutations, so callers without that timestamp now fail validation.createHarnessCloudAgentContextbinds time and arguments ininputDigestand replaces hash-onlymessageIdvalues with stable identifiers matching the software development kit (SDK) ordering.Mutation callers must authorize the new digest; reads retain their argument-only digest and now return
undefinedformessageId.Files
apps/web/src/lib/agent-harness/cloud-agent-context.ts— Source, M (modified), 62 changed lines; binds mutation timestamps, formats SDK-compatible message identifiers, and adds sanitized admission normalization.apps/web/src/lib/agent-harness/cloud-agent-test-fixture.ts— Test fixture, M (modified), 27 changed lines; uses canonical digests, supplies fixed mutation timestamps, and checks the input digest and definition version.normalizeCloudAgentAdmissionErrorsanitizes localTRPCErrorand verified remoteTRPCClientErrorrejections;AdmissionCodepermits onlyUNAUTHORIZED,FORBIDDEN,BAD_REQUEST,PRECONDITION_FAILED, andPAYMENT_REQUIRED.It unwraps at most four
INTERNAL_SERVER_ERRORserver wrappers;RemoteAdmissionrequires matching numeric error codes and Hypertext Transfer Protocol (HTTP) statuses.Recognized rejections receive a fixed message without causes; transport loss, outages, timeouts, conflicts, and malformed errors return
undefinedinstead of confirming rejection.Files
apps/web/src/lib/agent-harness/cloud-agent-context.test.ts— Test, M (modified), 109 changed lines; covers identity stability, SDK ordering, mutation authorization, invalid timestamps, sanitized admission rejections, and uncertain remote failures.The implementation reports six passing scoped commands and 65 automated tests, including seven Worker tests.
These results do not prove live service behavior.
Tests: 3 files changed, totaling 315 changed lines:
cloud-agent-context.test.ts(modified),cloud-agent-test-fixture.ts(modified), andcloud-agent-dispatch.test.ts(added).Generated: 0 files changed.
Visual Changes
Visual Changes: N/A
Verification
No manual or live service tests are reported for this level because it adds prerequisites without activating the harness.
Continuous integration (CI) owns database execution and project-wide types.
Reviewer Notes
Kilo-Org/cloud:/Users/igor/Projects/.worktrees/shared-agent-harness-3bb0.shared-agent-harness-3bb0-s21...shared-agent-harness-3bb0-s22.Human steps: None required before merge or after merge.
Runtime verification remains pending at the stack tip. This level adds dispatch prerequisites without activating the harness.
Stacked PRs — merge bottom to top. Each level shows only its own diff.
Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.
shared-agent-harness-3bb0— chore(agent-harness): register workspaces and enforce CI boundaries #5632shared-agent-harness-3bb0-s2— feat(agent-harness): define portable domain and snapshots #5637shared-agent-harness-3bb0-s3— feat(agent-harness): define commands tools and permission policy #5639shared-agent-harness-3bb0-s4— feat(agent-harness): share client state and cursor recovery #5643shared-agent-harness-3bb0-s5— feat(agent-harness): persist command intents and execution receipts #5647shared-agent-harness-3bb0-s6— feat(db): add harness ingress grants and retirement fences #5655shared-agent-harness-3bb0-s7— feat(agent-harness): deliver legacy history and project durable text #5659shared-agent-harness-3bb0-s8— feat(agent-harness): authorize durable grants and registered clients #5662shared-agent-harness-3bb0-s9— feat(agent-harness): fence retirement and retry payload cleanup #5667shared-agent-harness-3bb0-s10— feat(agent-harness): persist authoritative state in SQLite #5675shared-agent-harness-3bb0-s11— feat(agent-harness): admit durable runs and revisioned commands #5678shared-agent-harness-3bb0-s12— feat(agent-harness): recover queued runs and stream checkpointed steps #5688shared-agent-harness-3bb0-s13— feat(agent-harness): resolve interactions and dispatch tools sequentially #5693shared-agent-harness-3bb0-s14— feat(agent-harness): fence designated client tool execution #5697shared-agent-harness-3bb0-s15— feat(agent-harness): synchronize durable snapshots and legacy history #5701shared-agent-harness-3bb0-s16— feat(agent-harness): reuse authorized invitations with durable replay #5704shared-agent-harness-3bb0-s17— feat(integrations): bound repository transport for harness reads #5710shared-agent-harness-3bb0-s18— feat(integrations): expose bounded authorized repository reads #5714shared-agent-harness-3bb0-s19— feat(agent-harness): expose named authorized resource reads #5718shared-agent-harness-3bb0-s20— feat(sessions): bound history transport for harness reads #5724shared-agent-harness-3bb0-s21— feat(agent-harness): read scoped Cloud Agent context and progress #5726shared-agent-harness-3bb0-s22— fix(agent-harness): preserve ordered Cloud Agent dispatch identity #5731 ← this PRshared-agent-harness-3bb0-s23— feat(agent-harness): hand coding work to authorized Cloud Agent sessions #5733shared-agent-harness-3bb0-s24— feat(agent-harness): authorize scoped MCP gateway connections #5737shared-agent-harness-3bb0-s25— feat(agent-harness): bound MCP gateway transport in the Worker #5740shared-agent-harness-3bb0-s26— feat(agent-harness): execute validated remote MCP tools #5743shared-agent-harness-3bb0-s27— refactor(exa): share provider dispatch and usage recording #5746shared-agent-harness-3bb0-s28— feat(agent-harness): authorize bounded web provider requests #5747shared-agent-harness-3bb0-s29— feat(agent-harness): normalize web sources and preserve citations #5749shared-agent-harness-3bb0-s30— feat(agent-harness): define closed internal operation contracts #5753shared-agent-harness-3bb0-s31— feat(agent-harness): authorize internal maintenance operations #5754shared-agent-harness-3bb0-s32— feat(agent-harness): authorize named Kilo operation dispatch #5755shared-agent-harness-3bb0-s33— feat(agent-harness): authorize internal provider operations #5757shared-agent-harness-3bb0-s34— feat(agent-harness): secure the internal operations endpoint #5758shared-agent-harness-3bb0-s35— feat(agent-harness): bound and sanitize model streams #5767shared-agent-harness-3bb0-s36— feat(agent-harness): secure billed model inference #5776shared-agent-harness-3bb0-s37— test(agent-harness): cover model gateway security boundaries #5777 (tip)