Skip to content

fix(agent-harness): preserve ordered Cloud Agent dispatch identity - #5731

Closed
iscekic wants to merge 3 commits into
shared-agent-harness-3bb0-s21from
shared-agent-harness-3bb0-s22
Closed

fix(agent-harness): preserve ordered Cloud Agent dispatch identity#5731
iscekic wants to merge 3 commits into
shared-agent-harness-3bb0-s21from
shared-agent-harness-3bb0-s22

Conversation

@iscekic

@iscekic iscekic commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

No new behavior — this change adds internal safeguards without enabling new product features.


Summary

Fresh SchedulerAdapter.dispatch calls require numeric dispatchStartedAt; SchedulerAdapter.reconciliation.read receives the original reservation time or explicit legacy undefined through ToolExecution.
Reconciliation matches the original attempt and call, excludes released reservations, and preserves identity across restarts without substituting the recovery time.
Without that timestamp, kilo.sessions.* mutations remain outcome_unknown without lookup or redispatch; other adapters retain legacy reconciliation.

Files
  • services/agent-harness/src/scheduler.ts — Source, M (modified), 23 changed lines; passes the original reservation timestamp and guards legacy Cloud Agent reconciliation.
  • services/agent-harness/src/cloud-agent-dispatch.test.ts — Test, A (added), 179 changed lines; checks Durable Object restart recovery, stable dispatch identity, no repeated effects, and legacy reconciliation.

Invocation adds dispatchStartedAt; DispatchTime requires a nonnegative safe integer for mutations, so callers without that timestamp now fail validation.
createHarnessCloudAgentContext binds time and arguments in inputDigest and replaces hash-only messageId values with stable identifiers matching the software development kit (SDK) ordering.
Mutation callers must authorize the new digest; reads retain their argument-only digest and now return undefined for messageId.

Files
  • apps/web/src/lib/agent-harness/cloud-agent-context.ts — Source, M (modified), 62 changed lines; binds mutation timestamps, formats SDK-compatible message identifiers, and adds sanitized admission normalization.
  • apps/web/src/lib/agent-harness/cloud-agent-test-fixture.ts — Test fixture, M (modified), 27 changed lines; uses canonical digests, supplies fixed mutation timestamps, and checks the input digest and definition version.

normalizeCloudAgentAdmissionError sanitizes local TRPCError and verified remote TRPCClientError rejections; AdmissionCode permits only UNAUTHORIZED, FORBIDDEN, BAD_REQUEST, PRECONDITION_FAILED, and PAYMENT_REQUIRED.
It unwraps at most four INTERNAL_SERVER_ERROR server wrappers; RemoteAdmission requires matching numeric error codes and Hypertext Transfer Protocol (HTTP) statuses.
Recognized rejections receive a fixed message without causes; transport loss, outages, timeouts, conflicts, and malformed errors return undefined instead of confirming rejection.

Files
  • apps/web/src/lib/agent-harness/cloud-agent-context.test.ts — Test, M (modified), 109 changed lines; covers identity stability, SDK ordering, mutation authorization, invalid timestamps, sanitized admission rejections, and uncertain remote failures.

The implementation reports six passing scoped commands and 65 automated tests, including seven Worker tests.
These results do not prove live service behavior.

Tests: 3 files changed, totaling 315 changed lines: cloud-agent-context.test.ts (modified), cloud-agent-test-fixture.ts (modified), and cloud-agent-dispatch.test.ts (added).
Generated: 0 files changed.


Visual Changes

Visual Changes: N/A

Verification

No manual or live service tests are reported for this level because it adds prerequisites without activating the harness.
Continuous integration (CI) owns database execution and project-wide types.

Reviewer Notes

  • Worktree for Kilo-Org/cloud: /Users/igor/Projects/.worktrees/shared-agent-harness-3bb0.
  • Review range: shared-agent-harness-3bb0-s21...shared-agent-harness-3bb0-s22.
  • Scope: level 22 dispatch identity and admission errors; no mutation adapters, composition, or presentation.

Human steps: None required before merge or after merge.

Runtime verification remains pending at the stack tip. This level adds dispatch prerequisites without activating the harness.

Stacked PRs — merge bottom to top. Each level shows only its own diff.

Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.

  1. shared-agent-harness-3bb0chore(agent-harness): register workspaces and enforce CI boundaries #5632
  2. shared-agent-harness-3bb0-s2feat(agent-harness): define portable domain and snapshots #5637
  3. shared-agent-harness-3bb0-s3feat(agent-harness): define commands tools and permission policy #5639
  4. shared-agent-harness-3bb0-s4feat(agent-harness): share client state and cursor recovery #5643
  5. shared-agent-harness-3bb0-s5feat(agent-harness): persist command intents and execution receipts #5647
  6. shared-agent-harness-3bb0-s6feat(db): add harness ingress grants and retirement fences #5655
  7. shared-agent-harness-3bb0-s7feat(agent-harness): deliver legacy history and project durable text #5659
  8. shared-agent-harness-3bb0-s8feat(agent-harness): authorize durable grants and registered clients #5662
  9. shared-agent-harness-3bb0-s9feat(agent-harness): fence retirement and retry payload cleanup #5667
  10. shared-agent-harness-3bb0-s10feat(agent-harness): persist authoritative state in SQLite #5675
  11. shared-agent-harness-3bb0-s11feat(agent-harness): admit durable runs and revisioned commands #5678
  12. shared-agent-harness-3bb0-s12feat(agent-harness): recover queued runs and stream checkpointed steps #5688
  13. shared-agent-harness-3bb0-s13feat(agent-harness): resolve interactions and dispatch tools sequentially #5693
  14. shared-agent-harness-3bb0-s14feat(agent-harness): fence designated client tool execution #5697
  15. shared-agent-harness-3bb0-s15feat(agent-harness): synchronize durable snapshots and legacy history #5701
  16. shared-agent-harness-3bb0-s16feat(agent-harness): reuse authorized invitations with durable replay #5704
  17. shared-agent-harness-3bb0-s17feat(integrations): bound repository transport for harness reads #5710
  18. shared-agent-harness-3bb0-s18feat(integrations): expose bounded authorized repository reads #5714
  19. shared-agent-harness-3bb0-s19feat(agent-harness): expose named authorized resource reads #5718
  20. shared-agent-harness-3bb0-s20feat(sessions): bound history transport for harness reads #5724
  21. shared-agent-harness-3bb0-s21feat(agent-harness): read scoped Cloud Agent context and progress #5726
  22. shared-agent-harness-3bb0-s22fix(agent-harness): preserve ordered Cloud Agent dispatch identity #5731 ← this PR
  23. shared-agent-harness-3bb0-s23feat(agent-harness): hand coding work to authorized Cloud Agent sessions #5733
  24. shared-agent-harness-3bb0-s24feat(agent-harness): authorize scoped MCP gateway connections #5737
  25. shared-agent-harness-3bb0-s25feat(agent-harness): bound MCP gateway transport in the Worker #5740
  26. shared-agent-harness-3bb0-s26feat(agent-harness): execute validated remote MCP tools #5743
  27. shared-agent-harness-3bb0-s27refactor(exa): share provider dispatch and usage recording #5746
  28. shared-agent-harness-3bb0-s28feat(agent-harness): authorize bounded web provider requests #5747
  29. shared-agent-harness-3bb0-s29feat(agent-harness): normalize web sources and preserve citations #5749
  30. shared-agent-harness-3bb0-s30feat(agent-harness): define closed internal operation contracts #5753
  31. shared-agent-harness-3bb0-s31feat(agent-harness): authorize internal maintenance operations #5754
  32. shared-agent-harness-3bb0-s32feat(agent-harness): authorize named Kilo operation dispatch #5755
  33. shared-agent-harness-3bb0-s33feat(agent-harness): authorize internal provider operations #5757
  34. shared-agent-harness-3bb0-s34feat(agent-harness): secure the internal operations endpoint #5758
  35. shared-agent-harness-3bb0-s35feat(agent-harness): bound and sanitize model streams #5767
  36. shared-agent-harness-3bb0-s36feat(agent-harness): secure billed model inference #5776
  37. shared-agent-harness-3bb0-s37test(agent-harness): cover model gateway security boundaries #5777 (tip)

This was referenced Aug 29, 2026
@kilo-code-bot

kilo-code-bot Bot commented Aug 29, 2026

Copy link
Copy Markdown
Contributor

Code Review Summary

Status: No Issues Found | Recommendation: Merge

Files Reviewed (5 files)
  • apps/web/src/lib/agent-harness/cloud-agent-context.ts
  • apps/web/src/lib/agent-harness/cloud-agent-context.test.ts
  • apps/web/src/lib/agent-harness/cloud-agent-test-fixture.ts
  • services/agent-harness/src/cloud-agent-dispatch.test.ts
  • services/agent-harness/src/scheduler.ts

Reviewed by grok-4.6 · Input: 463.5K · Output: 27.6K · Cached: 1M

Review guidance: REVIEW.md from base branch shared-agent-harness-3bb0-s21

@iscekic

iscekic commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

Closing: the owner stopped this workflow section. The branch is retained.

@iscekic iscekic closed this Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant