feat(agent-harness): secure billed model inference - #5776
Closed
iscekic wants to merge 1 commit into
Closed
Conversation
This was referenced Aug 31, 2026
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (3 files)
Reviewed by grok-4.6 · Input: 117.3K · Output: 22.5K · Cached: 1.4M Review guidance: REVIEW.md from base branch |
This was referenced Aug 31, 2026
This was referenced Aug 31, 2026
Contributor
Author
|
Closing: the owner stopped this workflow section. The branch is retained. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current Quick Chat experience stays unchanged. This adds a protected model endpoint for the shared harness.
Summary
The new
POST /api/internal/agent-harness/modelroute requires service authentication andagent-harness:modelcapabilities;InputandharnessModelScopebind requests to current primary authority.proxyHarnessModelmints five-minute user tokens for the existing billed gateway, retaining policy checks, organization billing, and Quick Chat attribution.Bounded streaming preserves progressive output, identifiers, cancellation, empty output, and sanitized failures;
maxDurationpermits 100 seconds around the 90-second request deadline.Files
apps/web/src/lib/agent-harness/model-gateway.ts— adds the server-only proxy and capability scope. Checks existingINTERNAL_API_SECRETwith a timing-safe comparison and requires a Bearer capability; ordinary client tokens cannot authorize inference. Readsx-agent-harness-conversation-id,x-agent-harness-run-id, andx-agent-harness-operation-id. Validates bounded JavaScript Object Notation (JSON) bodies with strict 8-bit Unicode Transformation Format (UTF-8) decoding. Requires a nonempty trimmed model, messages,stream: true, andmax_tokensbetween 1 and 8192. Allows optionaln: 1and function tools; rejectsmax_completion_tokensandpluginswhile retaining other completion fields. The scope includes the input digest, dispatch identity, model audience, definition version1, and backend target. Delegates current grant, conversation, user, and membership checks to the existing authorizer. Creates a token withtokenSource: 'agent-harness'and posts the completion to/api/openrouter/chat/completionsunder existingAPP_URL, with redirects disabled. The billed gateway retains eligibility, balance checks, free-model exceptions, bring-your-own-key exceptions, and charges. Uses the authorized organization instead of incoming attribution, setsFEATURE_HEADERtoquick-chat, and maps identifiers tox-kilo-request,x-kilocode-taskid, andx-kilo-session. ComposesboundedBodyandstreamHarnessModelwith request cancellation, reader cancellation, the deadline, andno-storeresponses. Keeps server credentials out of returned headers, output, checkpoints, and logs. Shared messages classify access, limits, cancellation, invalid input/output, and availability failures. Invalid request UTF-8 returns 400; invalid upstream UTF-8 produces 422; transport failures return retryable 503. Marks onlystorage_unavailableerrors as retryable.apps/web/src/app/api/internal/agent-harness/model/route.ts— adds thePOSTexport throughproxyHarnessModeland setsmaxDurationto 100 seconds. Existing routes and stored formats remain unchanged.Tests: 1 file added —
apps/web/src/lib/agent-harness/model-gateway.test.ts(+268/−0 lines), with 27 focused cases. Covers authorization, inference validation, billing attribution, progressive output, both UTF-8 boundaries, sanitized transport errors, cancellation, and terminal-only empty output.Generated: 0 files changed.
Verification
Manual and end-to-end (E2E) verification did not run because Worker composition and the completed runtime stack remain pending.
Visual Changes
Visual Changes: N/A
Reviewer Notes
Recorded checks and scope
Human steps
No action is required before merge or after merge for this level.
Notes
Stacked PRs — merge bottom to top. Each level shows only its own diff.
Runtime verification (E2E, user advocacy, simplify) runs on the tip PR over every level.
Every level keeps its own checks, its own bot review, and its own threads; each one is answered on its own PR.
Each level is its own deliverable: it builds and passes its own checks alone.
A finding on a level is repaired on that level, then carried upward with stack.sh forward.
shared-agent-harness-3bb0— chore(agent-harness): register workspaces and enforce CI boundaries #5632shared-agent-harness-3bb0-s2— feat(agent-harness): define portable domain and snapshots #5637shared-agent-harness-3bb0-s3— feat(agent-harness): define commands tools and permission policy #5639shared-agent-harness-3bb0-s4— feat(agent-harness): share client state and cursor recovery #5643shared-agent-harness-3bb0-s5— feat(agent-harness): persist command intents and execution receipts #5647shared-agent-harness-3bb0-s6— feat(db): add harness ingress grants and retirement fences #5655shared-agent-harness-3bb0-s7— feat(agent-harness): deliver legacy history and project durable text #5659shared-agent-harness-3bb0-s8— feat(agent-harness): authorize durable grants and registered clients #5662shared-agent-harness-3bb0-s9— feat(agent-harness): fence retirement and retry payload cleanup #5667shared-agent-harness-3bb0-s10— feat(agent-harness): persist authoritative state in SQLite #5675shared-agent-harness-3bb0-s11— feat(agent-harness): admit durable runs and revisioned commands #5678shared-agent-harness-3bb0-s12— feat(agent-harness): recover queued runs and stream checkpointed steps #5688shared-agent-harness-3bb0-s13— feat(agent-harness): resolve interactions and dispatch tools sequentially #5693shared-agent-harness-3bb0-s14— feat(agent-harness): fence designated client tool execution #5697shared-agent-harness-3bb0-s15— feat(agent-harness): synchronize durable snapshots and legacy history #5701shared-agent-harness-3bb0-s16— feat(agent-harness): reuse authorized invitations with durable replay #5704shared-agent-harness-3bb0-s17— feat(integrations): bound repository transport for harness reads #5710shared-agent-harness-3bb0-s18— feat(integrations): expose bounded authorized repository reads #5714shared-agent-harness-3bb0-s19— feat(agent-harness): expose named authorized resource reads #5718shared-agent-harness-3bb0-s20— feat(sessions): bound history transport for harness reads #5724shared-agent-harness-3bb0-s21— feat(agent-harness): read scoped Cloud Agent context and progress #5726shared-agent-harness-3bb0-s22— fix(agent-harness): preserve ordered Cloud Agent dispatch identity #5731shared-agent-harness-3bb0-s23— feat(agent-harness): hand coding work to authorized Cloud Agent sessions #5733shared-agent-harness-3bb0-s24— feat(agent-harness): authorize scoped MCP gateway connections #5737shared-agent-harness-3bb0-s25— feat(agent-harness): bound MCP gateway transport in the Worker #5740shared-agent-harness-3bb0-s26— feat(agent-harness): execute validated remote MCP tools #5743shared-agent-harness-3bb0-s27— refactor(exa): share provider dispatch and usage recording #5746shared-agent-harness-3bb0-s28— feat(agent-harness): authorize bounded web provider requests #5747shared-agent-harness-3bb0-s29— feat(agent-harness): normalize web sources and preserve citations #5749shared-agent-harness-3bb0-s30— feat(agent-harness): define closed internal operation contracts #5753shared-agent-harness-3bb0-s31— feat(agent-harness): authorize internal maintenance operations #5754shared-agent-harness-3bb0-s32— feat(agent-harness): authorize named Kilo operation dispatch #5755shared-agent-harness-3bb0-s33— feat(agent-harness): authorize internal provider operations #5757shared-agent-harness-3bb0-s34— feat(agent-harness): secure the internal operations endpoint #5758shared-agent-harness-3bb0-s35— feat(agent-harness): bound and sanitize model streams #5767shared-agent-harness-3bb0-s36— feat(agent-harness): secure billed model inference #5776 ← this PRshared-agent-harness-3bb0-s37— test(agent-harness): cover model gateway security boundaries #5777 (tip)