Skip to content

fix(controllers): persist Cruise Control results across conflicts - #397

Open
amuraru wants to merge 3 commits into
mainfrom
modernize/lifecycle
Open

amuraru wants to merge 3 commits into
mainfrom
modernize/lifecycle

Conversation

@amuraru

@amuraru amuraru commented Nov 16, 2026 •

Copy link
Copy Markdown

Description

Persist Cruise Control results across status conflicts without resubmitting external work; direct GETs occur only on conflict retries. Remaining lifecycle work is tracked in #391 under #368.

No automatic adoption or exactly-once guarantee.

Validation:

  • make test ENVTEST_K8S_VERSION=1.35.0: passed.
  • bin/golangci-lint run ./controllers/...: passed.
  • git diff --check: passed.

Not run locally for the latest commit: 1.37.0 suite, Kind E2E, crash/failover adoption tests, or benchmarks.

Type of Change

  • Bug Fix
  • New Feature
  • Breaking Change
  • Refactor
  • Documentation
  • Other (please describe)

Checklist

  • I have read the contributing guidelines
  • Existing issues have been referenced (where applicable)
  • I have verified this change is not present in other open pull requests
  • Functionality is documented
  • All code style checks pass
  • New code contribution is covered by automated tests
  • All new and existing tests pass

@amuraru
amuraru force-pushed the modernize/lifecycle branch from 15b239b to 4be2662 Compare November 16, 2026 15:59
@amuraru
amuraru force-pushed the modernize/foundation branch from 39778aa to f0df75e Compare November 16, 2026 15:59
@amuraru
amuraru force-pushed the modernize/lifecycle branch from 4be2662 to ea37a70 Compare November 16, 2026 16:52
@amuraru
amuraru force-pushed the modernize/foundation branch from f0df75e to 85215b7 Compare November 16, 2026 16:52
Base automatically changed from modernize/foundation to main November 16, 2026 17:49
@amuraru
amuraru force-pushed the modernize/lifecycle branch from ea37a70 to da63dc3 Compare November 16, 2026 17:54
@amuraru
amuraru marked this pull request as ready for review November 16, 2026 17:54
@amuraru amuraru changed the title fix(controllers): harden reconciliation lifecycle and status writes fix(controllers): persist Cruise Control results across conflicts Nov 17, 2026
amuraru and others added 3 commits November 21, 2026 15:15
…icts

Retry fresh API reads and status writes without repeating external submission. Preserve stop-operation identity and retry history, reject stale object/task identities, add seven regression cases, and document the remaining submit-before-persist crash window.

Refs #369.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reuse the selected operation for the first status write and read directly only when retrying a conflict. Cover conflict-free submission, retry, and stop paths. Refs #369.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
perf(controllers): scope Cruise Control operation retrieval (#393)

Use the cached cluster label only as a hint for an authoritative direct LIST. Fall back to the namespace LIST for missing or stale hints without adding direct GETs before conflict.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@amuraru
amuraru force-pushed the modernize/lifecycle branch from db822f3 to be634e1 Compare November 21, 2026 14:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant