Skip to content

fix(service): require stable numeric health sentinel endpoints - #731

Closed
luvs01 wants to merge 3 commits into
devfrom
devin/fix-sentinel-probe-address-20261012
Closed

luvs01 wants to merge 3 commits into
devfrom
devin/fix-sentinel-probe-address-20261012

Conversation

@luvs01

@luvs01 luvs01 commented Oct 12, 2026 •

Copy link
Copy Markdown
Owner

Summary

Require a stable numeric endpoint before the opt-in service health sentinel can use probe failures to authorize recovery.

  • Map default, localhost, and wildcard binds to numeric loopback. Other DNS bind names make the sentinel stand down while the proxy continues running.
  • Pin the first normalized address and port, then recheck the endpoint before probing, under the ownership lease, and immediately before termination.
  • Retain the existing parent identity, freshness, recovery-history, and shutdown checks; document the numeric-address requirement in the configuration reference and translations.

Verification

Current head: 8d57b33770c6ea9991e47f1374f97d74642a09b8.

  • Bun 1.4.3: bun test tests/service/service-health-sentinel-runner.test.ts tests/service/service-health-sentinel-policy.test.ts — 54 passed, 0 failed.
  • Three regressions failed before the fix: a forward clock jump or rollback during the final runtime read could authorize termination on stale evidence, and exit during that read still reached termination. The read now precedes the final age/exit checks; all three pass.
  • bun run typecheck, bun run structure:check, and git diff --check passed.
  • Current-head aggregate CI passed on 8d57b3377.
  • A full local repository run was not repeated across the active worktrees. The runner/policy files cover the changed ordering; completed hosted CI supplies broader coverage.
  • Review-thread inspection found no unresolved findings or outstanding change requests.

Checklist

  • Recovery authority is bound to a numeric, stable endpoint.
  • Regression coverage and current-head CI evidence are recorded.
  • Configuration documentation and translations are updated.

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@coderabbitai

coderabbitai Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: Repository: luvs01/opencodex/.coderabbit.yaml
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 57b05df6-5283-4ef5-86fe-1eebcb5f304f
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@luvs01

luvs01 commented Oct 12, 2026

Copy link
Copy Markdown
Owner Author

No description provided.

@github-actions github-actions Bot added the bug Something isn't working label Oct 13, 2026
@github-actions

Copy link
Copy Markdown

✅ Deterministic PR hygiene checks passed.

@luvs01
luvs01 marked this pull request as ready for review October 13, 2026 03:06
Co-authored-by: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@luvs01
luvs01 marked this pull request as draft October 13, 2026 06:04
@luvs01
luvs01 marked this pull request as ready for review October 13, 2026 06:37
@luvs01

luvs01 commented Oct 13, 2026

Copy link
Copy Markdown
Owner Author

Closing duplicate tracking after preserving the complete change in independently verified integration commit 9cb9f4d5cfb43991f09ecc1564e0dcbbfe533846 based on development revision 6da2774369aa32552e318e333902499683d053bc. All 12 changed files match source HEAD 8d57b33770c6ea9991e47f1374f97d74642a09b8 byte for byte. Pinned Bun 1.4.3 runner and policy tests passed 54 cases with 333 assertions. Type, structure, materialized-file privacy and diff checks passed; source-revision hosted CI also completed successfully. Integration remains unmerged and requires its own CI and maintainer review. The source branch is retained.

@luvs01 luvs01 closed this Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant