Skip to content

ci(cli): include observation in shared phase inventory - #4654

Open
yannickmonney wants to merge 1 commit into
mainfrom
ci/observer-shared-phase-inventory
Open

yannickmonney wants to merge 1 commit into
mainfrom
ci/observer-shared-phase-inventory

Conversation

@yannickmonney

Copy link
Copy Markdown
Contributor

The workspace unit job failed after the observation command suite was added: the shared source/compiled phase guard discovers observation.test.ts, but its explicit expected inventory omits it.

Add the observation suite to the alphabetical expected inventory. Discovery, shared helper assertions, closed inventory validation, source/compiled selection and all production tests remain unchanged.

Validation: unchanged focused assertion fails on main and passes with the one-line repair; all 32 tests in cli-workflow, ci-cli-parallel and ci-ready-workflows pass; the three observation source command tests pass. Full CLI typecheck, configured scoped lint/format, conflict and whitespace checks, strict scoped pinned SAST, and normal commit hooks pass. No full workspace or native compiled observation execution claim.

This was referenced Oct 9, 2026
@yannickmonney
yannickmonney added this pull request to the merge queue Oct 9, 2026
@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Oct 9, 2026
@yannickmonney

Copy link
Copy Markdown
Contributor Author

ACCEPT at 252f0dfc63fcfca7e8c39424a4d9df942631ee72 (base 7d178ca2a6b94aa6406134349d60f34a6d220baf)

Independent review by agent #2 (Independent Review, TALE-359 run 4e340ae0-eb4a-4242-8c42-69b5a1d916ed). I have no authorship role on this PR. This is API-only review: I ran no tests myself.

What changed: one line in tools/cli/scripts/cli-workflow.test.ts. observation.test.ts is added to the closed, alphabetical inventory of command suites that the test "every source/compiled command suite uses the shared phase selector" expects. Discovery, the per-file assertions and every production file are unchanged.

Verified

  • Inventory is complete at both the head and current main 277a17f074d5: I read every top-level tools/cli/tests/*.test.ts at both refs (9 files, smoke.test.ts excluded, matching the test's non-recursive Bun.Glob scan).
  • Composition: the test file is the same blob (1c7b3c01) at the PR base and on main, so the merged tree is current main plus this one line.
  • Old fails, new passes: without the line, the sorted discovered set contains observation.test.ts and the closed toEqual fails, which is the v0.5.81 CLI failure at d1373d84 (cli-workflow.test.ts:489) reported on TALE-360. With the line, the sets are equal.
  • CI at this head: Checks run 37946010534 (pull_request, attempt 1), 64 check runs: 23 success, 41 skipped, 0 failed.
    • All 7 CI ready contexts are green.
    • Unit (workspaces), job 113872317659, ran turbo run test --filter='!@tale/platform' with Tasks: 17 successful, 17 total and Cached: 0 cached, so the @tale/cli tests executed fresh at this head rather than replaying from cache.

Topics

  • CICD: fixes the deterministic CLI unit failure; fresh execution verified above.
  • CODE: alphabetical order kept; the closed inventory still detects any new suite.
  • WORKFLOW/release: this is required for a v0.5.81-or-later CLI build, but not sufficient on its own. The three Windows-only merge-group test failures reported on TALE-360 are separate and unrepaired here.
  • Not applicable: UX, A11Y, UI, LOCALE, DOCS, SECURITY, DATA, PERFORMANCE, RESOURCES, DEPLOYMENT, RECOVERY, PROVIDERS and OBSERVABILITY. The change is a test-only one-line inventory edit, with no product, runtime or data path.

@yannickmonney
yannickmonney force-pushed the ci/observer-shared-phase-inventory branch from 252f0df to 4ac08d8 Compare October 9, 2026 20:57

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant